Date:   Mon, 6 Dec 2021 10:45:35 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Dan Williams <dan.j.williams@intel.com>, rafael@kernel.org,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Li Yang <leoyang.li@nxp.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/18] driver core: platform: Rename
 platform_dma_configure()
Message-ID: <20211206144535.GB4670@nvidia.com>
References: <20211206015903.88687-1-baolu.lu@linux.intel.com>
 <20211206015903.88687-4-baolu.lu@linux.intel.com>
 <Ya3BYxrgkNK3kbGI@kroah.com>
 <Ya4abbx5M31LYd3N@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ya4abbx5M31LYd3N@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xm3id8NP6TpfRZLglNj8LG/3Gy+KDXzfylN6YczpWt572VZ/n810iiTcrlF5?=
 =?us-ascii?Q?NFCVXo/uvo5nCm/Z4RnM7LE0uEEbN1Miqauj2H5pbDIFuWYY3bcKZqt5MVEU?=
 =?us-ascii?Q?Y3bLbdwK9lG+iORI+N3lRg+Ebb2fNdmgBpsp135K2c0IdAp2fg30WcrnHvJx?=
 =?us-ascii?Q?BE48Ye63DLzIf+dFuMa5JBe8U95IoPMuiL4U2O/2j/tor9u2BVotcG0WS9dQ?=
 =?us-ascii?Q?SElVsJ28URgWijdHXHwjy7FfAn24IVfghqKZ1KdNzT8LAN1HHYvkvYVJhMRT?=
 =?us-ascii?Q?iZk5sYWM4/QkoYJ9b+zMytrId5O/8MQdNIdpPV/OiCnd5i118EiF57eBq/BX?=
 =?us-ascii?Q?+IPVEysxS9PLroeVMkQBfjekGwsMv9K5KJ+SzvW9giz9rTUPJpoTJKA2NF8b?=
 =?us-ascii?Q?anRFo7Hh1jgQ7NG6limL2Ys64zBZZZ0XsjOg2PLedOHqTQdVww2nmlS51iH9?=
 =?us-ascii?Q?JgjivRvVlSrZ+wqgYWwc4gD5VVKwR0bSbwPTgCFYhk6UNSWcDsi7GoJyulJd?=
 =?us-ascii?Q?gLSxUpV5vDxjJomAl2Apk2Wxgzk+5KCctn7JuLBakLRU2yaljpMPO8qprAQh?=
 =?us-ascii?Q?hulR6BuZfScgQPWIaqmPh9hGQcF4E4uf3b3G6SiTwVI8B1BjY/0au8JRqY94?=
 =?us-ascii?Q?/fsqbdnmZtxBby7z2F+JdCHkkMML+dyyfUIZinNJF/HV3UxuVTeszh7eTP0r?=
 =?us-ascii?Q?jl6cIelpGOl561juqvp93U+8QTEseeXAYTfjFS7yDiUILK8QM3RSW8B6lOVX?=
 =?us-ascii?Q?l+hF9a9hti8+2CGgJ1N7d5pY3p2ANcJ8R14KZydahUaWSShoJ9XGnrVFiDsz?=
 =?us-ascii?Q?vkVzIcJC/rsklfuRph+VjRT7q4iGqnf0I+ixBMaz570J62JOAaDF/UXfT3by?=
 =?us-ascii?Q?WK4eSDtBuFW2awJ2HRq4/rsqzB5yOp95VV+Vd61fRQmZ4DW8Jh+5fZyTj77A?=
 =?us-ascii?Q?6Lil8TDFKp+dD3M9S9PU+sZXcxjG3+znb2MLFPXDRfYvt1a0w+04K0KiHEwu?=
 =?us-ascii?Q?v9qXDuUuiVAvjNGi942ZuxeFe8sV0Hhr2sYrQZgbqj+jhbyF0tZcQzixsiPY?=
 =?us-ascii?Q?HSpRCoX4+15q6t6kJSZcAaRItDbJL5QR0X9HYalD9gG6OWJoor5NxIBajyda?=
 =?us-ascii?Q?FLUzWEZrWMYqUELfjw+sT98xakYPMX+RhvvWR2oblCZ8Nu/XAdTTz3snUX5X?=
 =?us-ascii?Q?U0bKVmmTxvl0Khr1HdRTIfU1gzgpulj06V6pdN+t79l8C81YClf9w47B5Ytg?=
 =?us-ascii?Q?2lS/chWz2ksIl/St8dBg+41Bc7Tx/jDclgAb7cUz3r1V4pjrNkNDp5N9hquI?=
 =?us-ascii?Q?jAvEqfHFO/SKe3FCFe4tOBwni7sE27IbTs/9E7ojRaQAyRA50NOEr8kMdSnL?=
 =?us-ascii?Q?OVVQ4RqM2271MZ2eOh4SCZnG75etEhs7Wf6tpJNBdgnyPy5jl5IB4l4SUfU4?=
 =?us-ascii?Q?rizYH9Sk10mlB1Tf1ho/cXWxo6RQ7ulmoh6DxdKsG7Tv7WZ5LgN+L2q24GuM?=
 =?us-ascii?Q?bP/6/J6/OAuZsJMmZ/Rf6sedIzQJVkrR4hMp+lrhRAcI33zw91ak5Chqlq2E?=
 =?us-ascii?Q?WC507GvF0/5o73oQ4f4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c11d5041-6440-4dfc-2389-08d9b8c7107a
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:45:36.6434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qvIg4lmCMSInrDtONKvkS/Yymr9nCbdcWNqr8uSZk1qqEjZGia+lH8eT4/uOVntT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5224
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 06, 2021 at 06:13:01AM -0800, Christoph Hellwig wrote:
> On Mon, Dec 06, 2021 at 08:53:07AM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 06, 2021 at 09:58:48AM +0800, Lu Baolu wrote:
> > > The platform_dma_configure() is shared between platform and amba bus
> > > drivers. Rename the common helper to firmware_dma_configure() so that
> > > both platform and amba bus drivers could customize their dma_configure
> > > callbacks.
> > 
> > Please, if you are going to call these functions "firmware_" then move
> > them to the drivers/firmware/ location, they do not belong in
> > drivers/base/platform.c anymore, right?
> 
> firmware seems rather misnamed anyway, amba doesn't reall have anything
> to do with "firmware".

IIRC the only thing this function does is touch ACPI and OF stuff?
Isn't that firmware?

AFAICT amba uses this because AMBA devices might be linked to DT
descriptions?

Jason