Date:   Mon, 6 Dec 2021 17:02:32 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Wedson Almeida Filho <wedsonaf@google.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Finn Behrens <me@kloenk.de>,
        Sven Van Asbroeck <thesven73@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        Wayne Campbell <wcampbell1995@gmail.com>
Subject: Re: [RFC PATCH 19/19] drivers: android: Binder IPC in Rust
Message-ID: <Ya40GOSIrWVC2ZSq@kroah.com>
References: <20211206140313.5653-1-ojeda@kernel.org>
 <20211206140313.5653-20-ojeda@kernel.org>
 <Ya4lu3k9HxLRe1Tv@kroah.com>
 <Ya4zco0QFG0K5kO+@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ya4zco0QFG0K5kO+@google.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 03:59:46PM +0000, Wedson Almeida Filho wrote:
> On Mon, Dec 06, 2021 at 04:01:15PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 06, 2021 at 03:03:13PM +0100, Miguel Ojeda wrote:
> > > From: Wedson Almeida Filho <wedsonaf@google.com>
> > > 
> > > A port to Rust of the Android Binder IPC mechanism.
> > > 
> > > This module is a work in progress and will be sent for review later
> > > on, as well as separately from the Rust support.
> > > 
> > > However, it is included to show how an actual working module
> > > written in Rust may look like.
> > 
> > Have you all tested this against the userspace binder tests?  And is it
> > up to date with the features of the in-kernel binder driver?
> 
> Very little has changed here since the last submission, namely: using
> credentials for security callbacks, and replacing `Arc` with `Ref` (i.e., using
> refcount_t to manage ref-counted allocations).
> 
> As the message tries to indicate, this is submitted as an example and WIP, it
> doesn't have feature parity with the C version yet.

You might want to say that in the changelog text so I don't keep asking
every time it gets posted :)

thanks,

greg k-h