Date:   Mon, 6 Dec 2021 21:08:13 +0500
From:   Ameer Hamza <amhamza.mgc@gmail.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     vkuznets@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, pbonzini@redhat.com,
        wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH v2] KVM: x86: fix for missing initialization of return
 status variable
Message-ID: <20211206160813.GA37599@hamza-OptiPlex-7040>
References: <87ee6q6r1p.fsf@redhat.com>
 <20211206102403.10797-1-amhamza.mgc@gmail.com>
 <Ya4uR7I/7yvrgl6c@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ya4uR7I/7yvrgl6c@google.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 03:37:43PM +0000, Sean Christopherson wrote:
> On Mon, Dec 06, 2021, Ameer Hamza wrote:
> > If undefined ioctl number is passed to the kvm_vcpu_ioctl_device_attr
> > function, it should return with error status.
> 
> No, if anything KVM should do KVM_BUG_ON() and return -EIO, because @ioctl is
> completely KVM controlled.  But I'd personally prefer we leave it as is, there's
> one call site that very clearly invokes the helper with only the three ioctls.
> It's not a strong preference though.
Thank you for your response. I agree with you, but I think in my
opinion, it would be nice to resolve coverity warning. Let me update the
patch according to your suggestions anyway.

Thanks,
Hamza.