Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 6 Dec 2021 09:18:38 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Wei Ming Chen <jj251510319013@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
        wim@linux-watchdog.org, vz@mleia.com
Subject: Re: [PATCH] watchdog: Fix file path that does not exist
Message-ID: <20211206171838.GA3423410@roeck-us.net>
References: <20211206144224.2931-1-jj251510319013@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206144224.2931-1-jj251510319013@gmail.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 10:42:24PM +0800, Wei Ming Chen wrote:
> All the file path are now under drivers/watchdog/ instead of
> drivers/char/watchdog/
> 

Having a file name in its source is pointless. If you want to make any
changes, please drop those file names instead.

Also, "Based on ..." is still correct, as it refers to where the code
was located when the driver was written, not where it is today.
That code may actually have been removed by now, and then what ?
Please do not change those locations.

Last but not least, the bcm63xx driver is about to be removed.
Please do not touch it to avoid unnecessary conflicts.

Thanks,
Guenter

> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
>  drivers/watchdog/davinci_wdt.c | 2 +-
>  drivers/watchdog/it8712f_wdt.c | 2 +-
>  drivers/watchdog/ixp4xx_wdt.c  | 2 +-
>  drivers/watchdog/max63xx_wdt.c | 2 +-
>  drivers/watchdog/pnx4008_wdt.c | 2 +-
>  drivers/watchdog/scx200_wdt.c  | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index e6eaba6bae5b..91e548ad046f 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * drivers/char/watchdog/davinci_wdt.c
> + * drivers/watchdog/davinci_wdt.c
>   *
>   * Watchdog driver for DaVinci DM644x/DM646x processors
>   *
> diff --git a/drivers/watchdog/it8712f_wdt.c b/drivers/watchdog/it8712f_wdt.c
> index 3ce6a58bd81e..cb60ed310ab6 100644
> --- a/drivers/watchdog/it8712f_wdt.c
> +++ b/drivers/watchdog/it8712f_wdt.c
> @@ -6,7 +6,7 @@
>   *
>   *	Based on info and code taken from:
>   *
> - *	drivers/char/watchdog/scx200_wdt.c
> + *	drivers/watchdog/scx200_wdt.c
>   *	drivers/hwmon/it87.c
>   *	IT8712F EC-LPC I/O Preliminary Specification 0.8.2
>   *	IT8712F EC-LPC I/O Preliminary Specification 0.9.3
> diff --git a/drivers/watchdog/ixp4xx_wdt.c b/drivers/watchdog/ixp4xx_wdt.c
> index 31b03fa71341..59369cf7f082 100644
> --- a/drivers/watchdog/ixp4xx_wdt.c
> +++ b/drivers/watchdog/ixp4xx_wdt.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * drivers/char/watchdog/ixp4xx_wdt.c
> + * drivers/watchdog/ixp4xx_wdt.c
>   *
>   * Watchdog driver for Intel IXP4xx network processors
>   *
> diff --git a/drivers/watchdog/max63xx_wdt.c b/drivers/watchdog/max63xx_wdt.c
> index 9e1541cfae0d..69349f1d0f34 100644
> --- a/drivers/watchdog/max63xx_wdt.c
> +++ b/drivers/watchdog/max63xx_wdt.c
> @@ -1,5 +1,5 @@
>  /*
> - * drivers/char/watchdog/max63xx_wdt.c
> + * drivers/watchdog/max63xx_wdt.c
>   *
>   * Driver for max63{69,70,71,72,73,74} watchdog timers
>   *
> diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
> index e0ea133c1690..94d54247fcab 100644
> --- a/drivers/watchdog/pnx4008_wdt.c
> +++ b/drivers/watchdog/pnx4008_wdt.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * drivers/char/watchdog/pnx4008_wdt.c
> + * drivers/watchdog/pnx4008_wdt.c
>   *
>   * Watchdog driver for PNX4008 board
>   *
> diff --git a/drivers/watchdog/scx200_wdt.c b/drivers/watchdog/scx200_wdt.c
> index 7b5e18323f3f..77e630797572 100644
> --- a/drivers/watchdog/scx200_wdt.c
> +++ b/drivers/watchdog/scx200_wdt.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
> -/* drivers/char/watchdog/scx200_wdt.c
> +/* drivers/watchdog/scx200_wdt.c
>  
>     National Semiconductor SCx200 Watchdog support
>