Date:   Mon, 6 Dec 2021 18:25:10 +0000
From:   Mark Brown <broonie@kernel.org>
To:     "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, swboyd@chromium.org,
        collinsd@codeaurora.org, subbaram@codeaurora.org,
        Das Srinagesh <gurus@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/6] dt-bindings: regulator: Add
 "regulator-min-dropout-voltage-microvolt"
Message-ID: <Ya5VhkggWdjYyTHL@sirena.org.uk>
References: <1637314953-4215-1-git-send-email-quic_c_skakit@quicinc.com>
 <1637314953-4215-2-git-send-email-quic_c_skakit@quicinc.com>
 <YZ+o9sQpECZSrieN@sirena.org.uk>
 <d828f2a1-03e8-d6ee-4ab7-39bf677093b7@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="QXyE3CVvg7TRqRac"
Content-Disposition: inline
In-Reply-To: <d828f2a1-03e8-d6ee-4ab7-39bf677093b7@quicinc.com>
Precedence: bulk


--QXyE3CVvg7TRqRac
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 06, 2021 at 06:33:26PM +0530, Satya Priya Kakitapalli (Temp) wrote:
> On 11/25/2021 8:47 PM, Mark Brown wrote:

> > Usually this is a fixed property of the regulator rather than something
> > that varies per board - why have a DT property?

> The min-dropout value (headroom) varies with boards, that's why we have a DT
> property for it. We overwrite the default value in driver with actual value
> read from DT

Interesting.  How exactly does that end up happening - presumably other
systems are going to run into it?

If you do have board designs which somehow managed to introduce
additional dropouts (seems pretty concerning TBH) then I think the best
way to handle that is to add a generic property for it and have that
either added on to or override the requirements of the regulator itself
which should continue to be defined in the driver.  That way only boards
with issues need to do anything which will avoid bugs with the property
being omitted in what should be the common case.

--QXyE3CVvg7TRqRac
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGuVYYACgkQJNaLcl1U
h9C3WQf+K77xrkRiIBmIBf/V2boYm9+lY/DGgIZHn5D9szW12BeI8WtJy/UvUoQ4
DXiAYZlHtTtYQ3aWxTvsOlkAcd3TDMzrAH2sOlwmOUc4zdjr+2cXXxyLt6VtNIpq
cISFU5qK9dpEgufmbMsZG+rDd5lQn4pwIy93Kj0yaANprvAyRGtTUH4K7SqFxIR7
PK9L2IwRIcI8yQZlb2GTetLhJ6zmSl81QSFSHHOYUGPCBgERJQR1tD1xKkmh/TAf
zTt9t9r27QfwuOHnlApBE3foPBWBNE4Xvx8UIXvth7sB4tePKP4ei+W2m19AaiDk
UQJo2djCLIZXswbGQk+9Mn1xGicstQ==
=+APw
-----END PGP SIGNATURE-----

--QXyE3CVvg7TRqRac--