Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32886C433FE for ; Mon, 6 Dec 2021 20:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240292AbhLFUDd (ORCPT ); Mon, 6 Dec 2021 15:03:33 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4217 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhLFUDb (ORCPT ); Mon, 6 Dec 2021 15:03:31 -0500 Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4J7DlN0Hd1z67Mmd; Tue, 7 Dec 2021 03:58:56 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 21:00:00 +0100 Received: from [10.47.82.161] (10.47.82.161) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 19:59:59 +0000 Subject: Re: [PATCH v2 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags To: Jens Axboe CC: , , , , References: <1638794990-137490-1-git-send-email-john.garry@huawei.com> <67feacc8-3da7-90de-cc0c-f8b529f84297@kernel.dk> <544f60f5-a367-a1a0-5a21-9708a7e8d2e1@huawei.com> <930e8d6b-1e5a-fc06-47de-9ea9fee9fcc0@kernel.dk> From: John Garry Message-ID: <2d4b2468-a5a8-cc8b-d238-92791a9e813c@huawei.com> Date: Mon, 6 Dec 2021 19:59:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <930e8d6b-1e5a-fc06-47de-9ea9fee9fcc0@kernel.dk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.82.161] X-ClientProxiedBy: lhreml721-chm.china.huawei.com (10.201.108.72) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2021 19:48, Jens Axboe wrote: >> The first two patches aren't fixes, but are general dev. As for the >> last, it prob should go as a fix for 5.16, but I was not sure how you >> would feel about that - it's not a trivial change, we're late in the >> cycle, and Kashyap was happy for 5.17 . >> Hi Jens, >> Let me know if the last could be accepted as a fix and I'll re-send >> separately with a fixes tag. > Regardless of whether it's going into 5.16 or 5.17 it should have a > fixes tag. ok, so patch 3/3 would fix commit e155b0c238b2 ("blk-mq: Use shared tags for shared sbitmap support") I'll reply to that one with a fixes tag and I think that b4 would pick it up in case. Cheers, John