Date:   Mon, 6 Dec 2021 14:17:00 -0600
From:   Rob Herring <robh@kernel.org>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     linux-renesas-soc@vger.kernel.org, linux-input@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marc Zyngier <maz@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: input: gpio-keys: Fix interrupts in
 example
Message-ID: <Ya5vvOtq2kgf9hkT@robh.at.kernel.org>
References: <cover.1638538079.git.geert+renesas@glider.be>
 <47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be>
Precedence: bulk

On Fri, 03 Dec 2021 14:35:06 +0100, Geert Uytterhoeven wrote:
> The "interrupts" property in the example looks weird:
>   - The type is not in the last cell,
>   - Level interrupts don't work well with gpio-keys, as they keep the
>     interrupt asserted as long as the key is pressed, causing an
>     interrupt storm.
> 
> Use a more realistic falling-edge interrupt instead.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!