Date:   Mon, 6 Dec 2021 13:08:13 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Florian Weimer <fweimer@redhat.com>
Cc:     "Paul E. McKenney via Libc-alpha" <libc-alpha@sourceware.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] nptl: Add rseq registration
Message-ID: <20211206210813.GF641268@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <cover.1638798186.git.fweimer@redhat.com>
 <9c58724d604e160ebda5f667331fa41416c0d12b.1638798186.git.fweimer@redhat.com>
 <1780152866.15126.1638809966443.JavaMail.zimbra@efficios.com>
 <871r2podt9.fsf@oldenburg.str.redhat.com>
 <1614144911.15213.1638816753026.JavaMail.zimbra@efficios.com>
 <87ilw1mu81.fsf@oldenburg.str.redhat.com>
 <20211206201122.GE641268@paulmck-ThinkPad-P17-Gen-1>
 <87k0ghlbsk.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k0ghlbsk.fsf@oldenburg.str.redhat.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 09:26:51PM +0100, Florian Weimer wrote:
> * Paul E. McKenney via Libc-alpha:
> 
> >> The C memory model is broken and does not prevent out-of-thin-air
> >> values.  As far as I know, this breaks single-copy atomicity.  In
> >> practice, compilers will not exercise the latitude offered by the memory
> >> model.  volatile does not ensure absence of data races.
> >
> > Within the confines of the standard, agreed, use of the volatile keyword
> > does not explicitly prevent data races.
> >
> > However, volatile accesses are (informally) defined to suffice for
> > device-driver memory accesses that communicate with devices, whether via
> > MMIO or DMA-style shared memory.  The device-driver firmware is often
> > written in C or C++.  So doesn't this informal device-driver guarantee
> > need to also do what is needed for userspace code that is communicating
> > with kernel code?  If not, why not?
> 
> The informal guarantee is probably good enough here, too.  However, the
> actual accesses are behind macros, and those macros use either
> non-volatile plain reads or inline assembler (which use
> single-instruction naturally aligned reads).

Agreed, a non-volatile plain read is quite dangerous in this context.

							Thanx, Paul