MIME-Version: 1.0
References: <20211206100209.31971-1-xianwei.zhao@amlogic.com> <f20968ff-667f-3fd9-3f8e-af8eced694f0@baylibre.com>
In-Reply-To: <f20968ff-667f-3fd9-3f8e-af8eced694f0@baylibre.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 6 Dec 2021 22:25:33 +0100
Message-ID: <CAFBinCC42vo0WydYeodgjiMH676J75kaPyVtURmmdoL0=Of=6w@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: add support for S4 based Amlogic AQ222
To:     "xianwei.zhao" <xianwei.zhao@amlogic.com>
Cc:     Neil Armstrong <narmstrong@baylibre.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Dec 6, 2021 at 11:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
[...]
> > +/ {
> > +     model = "Amlogic";
>
> Please change to something like "Amlogic Meson S4 AQ222 Development Board"
>
> > +     compatible = "amlogic, aq222";
>
> Drop the space after amlogic, and add "amlogic,aq222" to the Documentation/devicetree/bindings/arm/amlogic.yaml bindings.
You can follow the approach from the Amlogic A1 SoC bringup, see
patches [0] and [1]

> You will probably need to add a new "amlogic,s4" family compatibla aswell.
For this (and various other code-review comments) you can also follow
the Amlogic A1 SoC (and AD401 board) bringup, see [2]


Best regards,
Martin


[0] https://patchwork.kernel.org/project/linux-amlogic/patch/1568276370-54181-3-git-send-email-jianxin.pan@amlogic.com/
[1] https://patchwork.kernel.org/project/linux-amlogic/patch/1568276370-54181-4-git-send-email-jianxin.pan@amlogic.com/
[2] https://patchwork.kernel.org/project/linux-amlogic/patch/1568276370-54181-5-git-send-email-jianxin.pan@amlogic.com/