From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Ameer Hamza <amhamza.mgc@gmail.com>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Topic: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Index: AQHX6hiZRK5cTb56bk2m5NVbTZyjx6wkenEwgAC48ICAAOYnsA==
Date:   Mon, 6 Dec 2021 23:19:36 +0000
Message-ID: <TYCPR01MB5581998AD64AE249C7D86C26D46D9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
References: <20211205204200.7852-1-amhamza.mgc@gmail.com>
 <TYCPR01MB55813B26BB2B3BB6D1E072F2D46C9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
 <20211206092937.GA5609@hamza-OptiPlex-7040>
In-Reply-To: <20211206092937.GA5609@hamza-OptiPlex-7040>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BWLILlyWwr2vgLOciQfnSFsNkY28u798HX0+TTQDyODl61IDuvNCLQaC5P/z?=
 =?us-ascii?Q?eDYlLKA/gww5BIwE+SGg8IA9tdvShmbr2Ub0g3KzyLRuo4MScFk11sv5i2sp?=
 =?us-ascii?Q?Y0Czq57YDKYQV6XAWjI9tp7+AluFBuWTJ2atjKi6OgzbvgdMeXaXDGwGjJtm?=
 =?us-ascii?Q?igfJi/+1d7p5zHJyB30kwoTwREmH6Noy6rrqXWVP1TIAN/jAebhIg2rJ5awP?=
 =?us-ascii?Q?IFcQRscP/aAjYzjs4Ex9XnYQeERYFYbiJRMvMH0s7Bs0sqixPdlm52v6x+Yf?=
 =?us-ascii?Q?snqpR+hAyN+yofxgQ3aMBjBFeXWivrIVOwZp3b1Wi532k+s92fyxmpT762jW?=
 =?us-ascii?Q?IJWckdELFtj4A8Avz1aw7iJq6xyTReIcsOOfOeurU1vaotmiMZsEIYomOG9R?=
 =?us-ascii?Q?4D9HnDLbUJCXHHMG9+oi8UHyKMCXp+vj3EmIAKIg+xqGBpDK0NgZ1DsbaLv6?=
 =?us-ascii?Q?GFK5luIN/kjG3fxBQxqMYp13JQRZQrwcJfPfJwMUr2l4FA0KiPQzia6rs5Pg?=
 =?us-ascii?Q?P2NEWxhPTCiUzuYuF2+F8DGtkgrI8Qh5hc3OYvTuw5nnKSl0QoLqvxVeUuGs?=
 =?us-ascii?Q?rfUg777naM6CaASYfoGxWpKWMGcJTjtfiRYdW7Fk6c0kpBAt6UhftJzDlI9b?=
 =?us-ascii?Q?MeL1DINXRlWbxVdsJf/tiRTcv+l26jSZeXiIYiVB6tEQdbwbGRDjT6nq5CXY?=
 =?us-ascii?Q?gWO5pMqeSpznS3XfXCqtfHfyEx01VK/MGmtWn46XsyZTJ3kq13uIUv4Fwrep?=
 =?us-ascii?Q?bmU1xqMkviQKl6FbA45MqWgiQKU0zeM+bb09kr2NAHeXEW4Jhcq0zBCdYKVz?=
 =?us-ascii?Q?PaT00V8kXA0R+o5yllRPQ1G9GhAs+/bQQ4ANaSdkhT6/R5qt3TX/2KyjAwzP?=
 =?us-ascii?Q?ptuFGAx2PMgkcXoI72dxMCb57SH5diqPquFjsXbXexlYfxrx+s2uh0RqcPan?=
 =?us-ascii?Q?zYbOs0eaMA2MgWjMDRHFpmGj0WVZzYr21jbssQRLVVsU+lxiEMollAW5L6uw?=
 =?us-ascii?Q?8cFWClvsOOiTRnVkIzYGQDhswjhBMadz/OtncIvMfeJp0ilYQZ8f+lDO6HRS?=
 =?us-ascii?Q?4w/0hInyDiH9wvD1QN3k6Px9TroP+W9ydQZhV3zEd+ubgXVKR9V77eTafRkn?=
 =?us-ascii?Q?7FzXyWixXlur2USxR776iN/VoeU5gFzXxkykB9zcpmTmqA4ApZ68olHlxWak?=
 =?us-ascii?Q?fzDTElgvKy6kuWwJf7Z1Pfjg/x/wop3omQ2H07EfbDtx61F2EWGOHXTMEYuV?=
 =?us-ascii?Q?lQtqJ2IfCorksH0eOv4o1f4Mh1U8nASPNTvQvEctoux27/6Mnvdd8BGIIe+D?=
 =?us-ascii?Q?UL56QC+Wdf0T2wJUnQsAAoBbQ5WRQ36wfRjbChukXSy8/Ln9D3Kj9EdXlqwz?=
 =?us-ascii?Q?Wy+sgG9EhwskVcUhXeTvNDtJ/Gj2R/Avp1yBX1zeU0F0KuBuF+uYAJ5KjUBj?=
 =?us-ascii?Q?tcQoDt6ND24CKLdODfnGLAsZOVy03Doswc/nlIrMigYqL8+dJjfbT51vFi5P?=
 =?us-ascii?Q?UqUKJgo+7BH/4T0RdS89H1i4djgPZNAmsAE724+flE3vweWpuS7lOdVyFkDY?=
 =?us-ascii?Q?vuc8vk3jpiJA9B+oGjXn/a7yfHSOVQDMvQGwS9bJicASDRR/7Tgb6R1zhWfb?=
 =?us-ascii?Q?e6Ry/xKV7FjUl4MwnXKxag7yi6NkprxcapLTinYp1pM3sFMk+jrE6If5mNpb?=
 =?us-ascii?Q?cT2Is20EuTmaaoKraA5dqT1r0wPak2UCDBjwZQ3lz5XXt3D+FIpDx4iBJUUA?=
 =?us-ascii?Q?V+eMLw04LA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB5581.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 658da310-2711-4f42-6af7-08d9b90eded7
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2021 23:19:36.7882
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U/gtHbFRgRF7cYKhbIoUAXiBYVImcbQw8NXI8+C2PjdusFVPvMeUlm1djGY+foSTERV3bE1eNevbc4qKlpHitMQjx0xJMD1deI5LDRVCIqKocNJnLThcMRRq1Pi8AOdS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB1981
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Ameer

>> Probing this driver without adata is strange for me.
>> How did probe this driver ??
>
> Thank you for your response. Unfortunately, I am not aware of
> implementation details of this component. Coverity suggested that there
> can be a potential NULL pointer access which seems logical to me. Do you
> agree with coverity here?

I think no potential NULL pointer access, because this driver can't
be called without of_id->data.
But, potential NULL pointer check itself is good idea.
It seems your patch was already accepted :)

I noticed that we can replace it to use of_device_get_match_data()

-	const struct of_device_id *of_id =3D of_match_device(test_of_match, &pdev=
->dev);
-	const struct test_adata *adata =3D of_id->data;
+	const struct test_adata *adata =3D of_device_get_match_data(&pdev->dev);


Best regards
---
Kuninori Morimoto