Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B56BBC433FE for ; Tue, 7 Dec 2021 02:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239574AbhLGCM7 (ORCPT ); Mon, 6 Dec 2021 21:12:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235404AbhLGCM6 (ORCPT ); Mon, 6 Dec 2021 21:12:58 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F1F4C061746; Mon, 6 Dec 2021 18:09:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1E2ADCE1993; Tue, 7 Dec 2021 02:09:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD89EC004DD; Tue, 7 Dec 2021 02:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638842964; bh=iZpY9szOk3KK1HWTm4hZk7WcVTv4QbN/GLI5/rhmcrg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cPl1HNb3lMfS9xk2wNnYW8sEB6SCV48hFOWCjUTg/ByZA/M71+Or/xorCOHLgkC9m W5SEhqVhMHmqib1irFhZrSx+I7zsJZS63XI/Jo/YoRSOCiQI4EsRlI59h6v5GOtbas saWoseGh793+Vm5qqBsXrsr4pidUA0FjanBxapwPT5YWPqu5+b9r+UhCYMgvuSgekM cAgbhUpIjV5lMmhe6vST+YPFpWk+HNN8IzCkmi2fHhLFT455DXLnwhADinprH9ylQz cZOUjyt1qpvtl6RI3w6CZeUly7IBs+kthy6lTtq1uaqOJuLf4B2fI6/IZ9TEL1evxp 5tGGJSfng92pw== Date: Mon, 6 Dec 2021 18:09:22 -0800 From: Jakub Kicinski To: Colin Foster Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Russell King Subject: Re: [PATCH v4 net-next 5/5] net: mscc: ocelot: expose ocelot wm functions Message-ID: <20211206180922.1efe4e51@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211204182858.1052710-6-colin.foster@in-advantage.com> References: <20211204182858.1052710-1-colin.foster@in-advantage.com> <20211204182858.1052710-6-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Dec 2021 10:28:58 -0800 Colin Foster wrote: > Expose ocelot_wm functions so they can be shared with other drivers. > > Signed-off-by: Colin Foster > Reviewed-by: Vladimir Oltean Yeah.. but there are no in-tree users of these. What's the story? I see Vladimir reviewed this so presumably we trust that the users will materialize rather quickly?