MIME-Version: 1.0
References: <20211206105530.0cd0a147@canb.auug.org.au> <20211206114348.37971224@canb.auug.org.au>
In-Reply-To: <20211206114348.37971224@canb.auug.org.au>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 6 Dec 2021 19:22:58 -0800
Message-ID: <CAEf4BzbiXhNk5xVQnZy11R697jmZEEQePwpSSNu+00x8hZ+Z1g@mail.gmail.com>
Subject: Re: linux-next: build warning after merge of the bpf-next tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Dec 5, 2021 at 4:44 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 6 Dec 2021 10:55:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the bpf-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > kernel/bpf/btf.c:6588:13: warning: 'purge_cand_cache' defined but not used [-Wunused-function]
> >  6588 | static void purge_cand_cache(struct btf *btf)
> >       |             ^~~~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> >   1e89106da253 ("bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().")
>
> And this is a build failure for my x86_64 allmodconfig build.  So I
> have used the bpf-next tree from next-20211202 again.

This should be fixed by [0] which I just applied to bpf-next, thanks
for letting us know! The reason you noticed this and we didn't is
because your version of pahole is probably older than what we use
typically and doesn't yet support kernel module BTFs.

  [0] https://patchwork.kernel.org/project/netdevbpf/patch/20211207014839.6976-1-alexei.starovoitov@gmail.com/


>
> --
> Cheers,
> Stephen Rothwell