Date:   Tue, 7 Dec 2021 12:23:46 +0900
From:   Akira Kawata <akirakawata1@gmail.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Eric Biederman <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: Unused local variable load_addr in load_elf_binary()
Message-ID: <20211207032346.g47nf4n6374xyaw2@gmail.com>
References: <CAKXUXMz1P8xCW+fjaiu0rvgJYmwHocMmtp+19u-+CQkLi=X2cw@mail.gmail.com>
 <202112061804.5185ACABD@keescook>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202112061804.5185ACABD@keescook>
Precedence: bulk

On Mon, Dec 06, 2021 at 06:04:56PM -0800, Kees Cook wrote:
> On Mon, Dec 06, 2021 at 04:46:01PM +0100, Lukas Bulwahn wrote:
> > Dear Akira-san,
> > 
> > With commit 0c9333606e30 ("fs/binfmt_elf: Fix AT_PHDR for unusual ELF
> > files"), you have changed load_elf_binary() in ./fs/binfmt_elf.c in a
> > way such that the local variable load_addr in load_elf_binary() is not
> > used anymore.
> 
> EEk! yeah, this totally broke ELF randomization. this needs to be
> entirely reverted.
> 
> -- 
> Kees Cook

I think my patch doesn't affect on ELF randomization because it keeps
the way of load_addr calculation.


Akira Kawata