MIME-Version: 1.0
References: <20211203195004.5803-1-alexandr.lobakin@intel.com>
In-Reply-To: <20211203195004.5803-1-alexandr.lobakin@intel.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 6 Dec 2021 19:35:20 -0800
Message-ID: <CAEf4BzZLt_ojTAf-=1nO2R7F8ROUwBdUsfp_W9NaAk-XSNEYmA@mail.gmail.com>
Subject: Re: [PATCH bpf 0/2] samples: bpf: fix build issues with Clang/LLVM
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@redhat.com>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 3, 2021 at 11:55 AM Alexander Lobakin
<alexandr.lobakin@intel.com> wrote:
>
> Samples, at least XDP ones, can be built only with the compiler used
> to build the kernel itself.
> However, XDP sample infra introduced in Aug'21 was probably tested
> with GCC/Binutils only as it's not really compilable for now with
> Clang/LLVM.
> These two are trivial fixes addressing this.
>
> Alexander Lobakin (2):
>   samples: bpf: fix xdp_sample_user.o linking with Clang
>   samples: bpf: fix 'unknown warning group' build warning on Clang
>

There were conflicts when applying, but luckily I was the one who
caused this conflict in XDP_SAMPLE_CFLAGS, so I just fixed it up
locally and pushed to bpf-next. Thanks.

>  samples/bpf/Makefile          | 5 +++++
>  samples/bpf/Makefile.target   | 2 +-
>  samples/bpf/xdp_sample_user.h | 2 ++
>  3 files changed, 8 insertions(+), 1 deletion(-)
>
> --
> 2.33.1
>