Message-ID: <1193986c-f55a-2fcf-c6ed-83350937ce91@oracle.com>
Date:   Mon, 6 Dec 2021 21:53:30 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH RESEND v2 2/5] dma-pool: allow user to disable atomic pool
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de,
        robin.murphy@arm.com, cl@linux.com, penberg@kernel.org,
        rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz,
        m.szyprowski@samsung.com, kexec@lists.infradead.org
References: <20211207030750.30824-1-bhe@redhat.com>
 <20211207030750.30824-3-bhe@redhat.com>
From:   John Donnelly <John.p.donnelly@oracle.com>
In-Reply-To: <20211207030750.30824-3-bhe@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnN0STYxWWhjS3lQbjZnWFl0YWtrZzBmTjZCeUhRM3QybWdQZkppUVI1Ukdn?=
 =?utf-8?B?YjN0MWltMUdnczdBbUJlV0QzajA2YWxaMmJhVmphb1ZPTWpMOWRYRGdZVGs3?=
 =?utf-8?B?bFV6d3VtK2JSQml3OENocEZTcEs4aTlOZDVWeU5tUEhWbFk1T1d1UlBLVndj?=
 =?utf-8?B?R2JvUjU5R080VElpM3pUTnpXdndESjhQZE9Dc1NoclZYMFpURHUzcjdlakhp?=
 =?utf-8?B?cXRYM0FQR3BOV0RPQ2FzZkdSbitGdHArQUF1Zmhrck5tZkZwZ3lEV1Erd2dV?=
 =?utf-8?B?T2sxNUtmaDRoWGJOcVlVUU9uTXVIRG1oOTk3WjgydXo1cFBuZTVTVVl5cXc2?=
 =?utf-8?B?R0owUW13TnB5Qmtmb1RBUm53bmNIUDRqNTBib0s5Nk5PRHBsb1BLL2N0SGRD?=
 =?utf-8?B?aEVPTzY1Z0ptSUwrVmZzWmJiRDVoUVlSYmhKVEFqcnBtdkNSSER6TGNQOHgr?=
 =?utf-8?B?V3FoUUNiQWV5VW81Y0pNUUJGd1VVL2JYOWdNL25Wb1NaUTRqcWhxTUpVS2x5?=
 =?utf-8?B?bkp6T1JyRGlPTXZ3ang0YkxMVHFObVduVVQzYU14dnF6Z0FXN0djdHBSVDky?=
 =?utf-8?B?M2o5Ymk0NVhXd0d2ajh0VmMyMGpVYS9va3lCNis4ZVBUUVNWY0tsSTBsNDBD?=
 =?utf-8?B?ZTB5aGdoZHBZY1JFQWtDdW1Td0xSQnlkNWJmcXlRZTB3aXZDT0g3OXlncnk5?=
 =?utf-8?B?MkJSQXVQV2U4UWRpb3hkeTBLRitEZGJTTFVGV1ZRM04vVVJFTlE1U0dJalVY?=
 =?utf-8?B?RmtsSzZOMkI1c0gxY21FdkVRQjRLUVVBb3NuR2VuS2hIVGR3QVJmUU9rVkMr?=
 =?utf-8?B?TFFOdGJlRGJxSFFCYUJpU28xbTgraHhxTXlkeVR0V0JpMkRLWWtxRkFqQVFy?=
 =?utf-8?B?VFpsVmMyaTZ6WFBoeTYvcEtzVmlFZmtIaG1wVlNQcXoyN3lDdnE1aTl2UEVi?=
 =?utf-8?B?V0Q5K3lGSjR6RjdFSEt3UU45UThrUzZQczR1NDZaNTdJWlB2aHlsc2xuTUtn?=
 =?utf-8?B?NWNEdkY5TkhXWTF2Q05SOC9jRzYrdklLZ3AzR0VwRlE2MHlhd0tEejZaQWcz?=
 =?utf-8?B?aHAydktUbU1nYlhoNWE1Kytwd1NHb0pPVXUyMFI2S3JJUXV2NDJsNDFuU0Fv?=
 =?utf-8?B?Nmk4TzVSYXJtTEpZRHExeGcyNlA1Q01FTW1JbmRQdzhaYkJFWlQ1RUZsNitH?=
 =?utf-8?B?OVd3Njg3SllFWFlvUEFxb0VBeFR3YjdNc3RlVHpwNlFvUWtoZVkvZTVqR0R2?=
 =?utf-8?B?Y0pGNXhNWGszQXppRUd5cHNTZ2xXOEUydkgwRGRFRUZETmtRSFNNa08wamZ2?=
 =?utf-8?B?dEYzY1NobzhUUFNGSm4zU2VvTUhyVUNIRk5IS2g0S0c4WUtwbVdGL2dIcE1E?=
 =?utf-8?B?WktSOTNtUm00Z2pWTjF2bFhFdVVmWlRuZ0MzOUNLR25kbStkUWx2MHdOVUJ3?=
 =?utf-8?B?QlBHaURZSHIxcWM3MXRyeGNkZnRmZE1Hb3NFNm1KNWFGR0pEQUVSM3Z4YlRY?=
 =?utf-8?B?NjhLSkdKR2loTEV0bDhMQzhKdk1nUVdHemhqdCtBaFRLM1J4R1FIVW94eURk?=
 =?utf-8?B?STRtUlAzZTlRdTZzUkp3QTd4UGFlSTBoQVQwVkJmM0pueTVWdDRYMnVlNEJB?=
 =?utf-8?B?cnNoMUxEOWFERFVPQUs1WEtWOElFVnJsdHpuZGRaejdjYll6RGdjRGduSnJq?=
 =?utf-8?B?aXZsMXlVZW12Mk81YXlGQ1pJMGFOMnl0S0ZRZTRBcWU2eldVREowS1hRSGRK?=
 =?utf-8?B?dWN3TWNjL0lZWk14OWJOcjYyZVJYM3BxblNsZG1xV1U4bjk3UjhZTVIyMDdC?=
 =?utf-8?B?UmN0cVYrMFptUXQ1YWhZRjFPWGVBQXlpb2FRZ0xacTMxb010bmU2dllxcFB5?=
 =?utf-8?B?SnhueEpJdlNGNjgrZFJzRUVtbjBobmFLM1VaaWdyNnJsWkFEdDJJM1FMWGxm?=
 =?utf-8?B?SzFkNjdlelY1N2lPUndLZC9ZS1lHY2NuRGIxU3NPV1BYYUg5RUdObG5vOUhG?=
 =?utf-8?B?SVFzeXI0WmZOOGxRWTN4SHRBYm1sM3FncVRFUjRVSDBWK0hUOU5uNlVBVk9p?=
 =?utf-8?B?YS95L1lJOW1xb1hBaE5rUzhSblhHejZzcXdtN3RJcitNeEY3ci9rdVhZeXdu?=
 =?utf-8?B?blZYbVJGM1gxV29PdDUvZWtyNlM0bmpkWlpCVk1zcTNKVFBwT3UvY3lUdUJ2?=
 =?utf-8?B?UDVMUGR5bHU1aVpucXVJYVIveUlYa3FJcy9YVFc0V1BMRnJETzdUVHVpVXYy?=
 =?utf-8?Q?B3NdanMb5rLH9a+3sd+2Lje7yZdrxLaIPn5oqfVGrw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b182ee7-313f-440c-7259-08d9b93524be
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 03:53:35.1907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RlYaGuDbO08nSJXLHjmCHVfiZVRxqdLiLmC/q7OTzxBbYuQcztxDh/VA2P9jNGOxwNvlueRB0+SWU0aY5bDT5b/RvmGc0Bhcmplxu4Xo5SU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4514
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10190 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112070022
X-Proofpoint-ORIG-GUID: lNqQI5jzWdBqr0ZXGOsQTQSquvcfObB_
X-Proofpoint-GUID: lNqQI5jzWdBqr0ZXGOsQTQSquvcfObB_
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/6/21 9:07 PM, Baoquan He wrote:
> In the current code, three atomic memory pools are always created,
> atomic_pool_kernel|dma|dma32, even though 'coherent_pool=0' is
> specified in kernel command line. In fact, atomic pool is only
> necessary when CONFIG_DMA_DIRECT_REMAP=y or mem_encrypt_active=y
> which are needed on few ARCHes.
> 
> So change code to allow user to disable atomic pool by specifying
> 'coherent_pool=0'.
> 
> Meanwhile, update the relevant document in kernel-parameter.txt.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>

  Reviewed-by: John Donnelly <john.p.donnelly@oracle.com>
  Tested-by:  John Donnelly <john.p.donnelly@oracle.com>
> ---
>   Documentation/admin-guide/kernel-parameters.txt | 3 ++-
>   kernel/dma/pool.c                               | 7 +++++--
>   2 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index ec4d25e854a8..d7015309614b 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -664,7 +664,8 @@
>   
>   	coherent_pool=nn[KMG]	[ARM,KNL]
>   			Sets the size of memory pool for coherent, atomic dma
> -			allocations. Otherwise the default size will be scaled
> +			allocations. A value of 0 disables the three atomic
> +			memory pool. Otherwise the default size will be scaled
>   			with memory capacity, while clamped between 128K and
>   			1 << (PAGE_SHIFT + MAX_ORDER-1).
>   
> diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
> index 5f84e6cdb78e..5a85804b5beb 100644
> --- a/kernel/dma/pool.c
> +++ b/kernel/dma/pool.c
> @@ -21,7 +21,7 @@ static struct gen_pool *atomic_pool_kernel __ro_after_init;
>   static unsigned long pool_size_kernel;
>   
>   /* Size can be defined by the coherent_pool command line */
> -static size_t atomic_pool_size;
> +static unsigned long atomic_pool_size = -1;
>   
>   /* Dynamic background expansion when the atomic pool is near capacity */
>   static struct work_struct atomic_pool_work;
> @@ -188,11 +188,14 @@ static int __init dma_atomic_pool_init(void)
>   {
>   	int ret = 0;
>   
> +	if (!atomic_pool_size)
> +		return 0;
> +
>   	/*
>   	 * If coherent_pool was not used on the command line, default the pool
>   	 * sizes to 128KB per 1GB of memory, min 128KB, max MAX_ORDER-1.
>   	 */
> -	if (!atomic_pool_size) {
> +	if (atomic_pool_size == -1) {
>   		unsigned long pages = totalram_pages() / (SZ_1G / SZ_128K);
>   		pages = min_t(unsigned long, pages, MAX_ORDER_NR_PAGES);
>   		atomic_pool_size = max_t(size_t, pages << PAGE_SHIFT, SZ_128K);
>