Date:   Tue, 7 Dec 2021 16:16:50 +1100
From:   Balbir Singh <bsingharora@gmail.com>
To:     yong w <yongw.pur@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>, mingo@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>, yang.yang29@zte.com.cn,
        wang.yong12@zte.com.cn
Subject: Re: [PATCH v2 linux-next] delayacct: track delays from memory compact
Message-ID: <Ya7uQingLC3fMJlt@balbir-desktop>
References: <1638619795-71451-1-git-send-email-wang.yong12@zte.com.cn>
 <Yax01zjuzmNyyJK/@balbir-desktop>
 <CAOH5QeDhjyjAkS1bUju2cv67KFukUr0ov8uG+z3bM6Oa=iFrMA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOH5QeDhjyjAkS1bUju2cv67KFukUr0ov8uG+z3bM6Oa=iFrMA@mail.gmail.com>
Precedence: bulk

On Sun, Dec 05, 2021 at 07:08:02PM +0800, yong w wrote:
> Balbir Singh <bsingharora@gmail.com> 于2021年12月5日周日 16:17写道：
> >
> > On Sat, Dec 04, 2021 at 04:09:55AM -0800, yongw.pur@gmail.com wrote:
> > > From: wangyong <wang.yong12@zte.com.cn>
> > >
> > > Delay accounting does not track the delay of memory compact.
> > > When there is not enough free memory, tasks can spend
> > > a amount of their time waiting for compact.
> > >
> > > To get the impact of tasks in direct memory compact, measure
> > > the delay when allocating memory through memory compact.
> > >
> >
> > Should we call this DIRECT_COMPACT and through documentation
> > or name change imply that this won't work for kcompactd the
> > kernel thread - based on my reading of the patches.
> >
> Using DIRECT_COMPACT is a little redundant，because the
> delayacct stats of delay accounting is specific to tasks, it has
> nothing to do with kcompactd, which is similar to the RECLAIM field.
>

What would we expect when we call delayacct -p <pidof kcompactd>
to be output? Yes, I agree with your comment on the reclaim
field. Don't feel to strongly, but it can be confusing that kcompactd
has spent no time in compact'ing? Not that delayacct is used for
kernel threads, but I am not sure if that use case exists today.

<snip>

Balbir Singh.