Date:   Mon, 6 Dec 2021 21:23:04 -0800
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
        Jiri Slaby <jslaby@suse.cz>,
        Peter Zijlstra <peterz@infradead.org>, ardb@kernel.org,
        broonie@kernel.org, catalin.marinas@arm.com,
        dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org,
        maz@kernel.org, mingo@redhat.com, tabba@google.com,
        tglx@linutronix.de, will@kernel.org
Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing
Message-ID: <20211207052304.pb76ofjymf7o2yyb@treble>
References: <20211206124715.4101571-1-mark.rutland@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211206124715.4101571-1-mark.rutland@arm.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote:
> This avoids repetition and hopefully make it easier to ensure
> consistency (e.g. so each function has a single canonical name and
> associated metadata).
> 
> I'm sending this as an RFC since I want to check:
> 
> a) People are happy with the idea in principle.
> 
> b) People are happy with the implementation within <linux/linkage.h>.
> 
> ... and I haven't yet converted the headers under tools/, which is
> largely a copy+paste job.

Looks like a definite improvement to me.

The only suggestion I'd have would be to fix a minor naming
inconsistency: change "SYM_FUNC_LOCAL_ALIAS" to "SYM_FUNC_ALIAS_LOCAL"
to match the other "<noun>_<verb>" macros.

-- 
Josh