From:   Yihao Han <hanyihao@vivo.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] net: dsa: felix: use kmemdup() to replace kmalloc + memcpy
Date:   Mon,  6 Dec 2021 22:44:18 -0800
Message-Id: <20211207064419.38632-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rahLCjeIP3NoQUG738zX4rHwFnPTdX3UvPdgxJfZ+TWNmUwjWa5lot9CkL96?=
 =?us-ascii?Q?5f8AdizQTZpFoAJ8lGuYPNI3ArOoklQENerlDGcgpLZwVWXvj8GddyY20Msh?=
 =?us-ascii?Q?8k8s1/h6Jrjqqffb+jMl8kxlqp8pYweCpZG4nUqMbdenHdFJv1vsJ7HkT6nW?=
 =?us-ascii?Q?QYMLOg8dRW4gcJBoobmDOa2snBXlb2/5lkOd/zwgUhJeJR+KXQIRfxZhkeRG?=
 =?us-ascii?Q?IkJEC9RiSfq8I4+broyqsq7AGzZc61sF1AuJPEg4txMSweNUB0uvvbV0dPNG?=
 =?us-ascii?Q?8JOriCW2QV9aXoE7cyzGKEv1k9LiLxijQ2pOmnuZBl2PrrFbZ+OJ1ilaAknj?=
 =?us-ascii?Q?4maGM+hCiAVtbBac98ggyXQPcDryoYabeQdp1wUchifh3gyBjiQDS0LgH3z2?=
 =?us-ascii?Q?lIey8MeXA3e5sepOR2jDVsIH+yYEUeiZ8nENKtm/bRIiumTNSAwLfGJF/uXK?=
 =?us-ascii?Q?31vwzeZzHsDDboFzVadaT3C2ZSgEq152I/ZPMhkVIGFxop2gHXjdK8O+g05D?=
 =?us-ascii?Q?5CFLWms33MP+mYxoKOXhshOf47V7XOFcNBU5C4qI68zPiamiwxT5mK8/TJyU?=
 =?us-ascii?Q?zSuDMDlgNZHLOHqiJ8XFuV/2nnw/CqJ2jyXiAxnb4sDGFRnC036Jzu/GRfnq?=
 =?us-ascii?Q?dSaG9Fphy1f+IZTklN2UxKpXrXV79CvpB+lvD9AV1RNu08CeK/2/uyz6GLQX?=
 =?us-ascii?Q?yVf51Mf9Q+KS6DzmwH7k0fHVxl7ii6bvZHx2ZuIwmGt/qmp536xuUTq7I9Ot?=
 =?us-ascii?Q?GiFGOOQREWBl29Vlku91jT1WMQ2unIINKeHUgiVXl6N8iZWOZJRecmYfmVaL?=
 =?us-ascii?Q?bg5lxKVO4uopA4rgXSlo4TiEgYxckhSAlUgvERGeW83lahnmowA/fOEvBaeN?=
 =?us-ascii?Q?+nbR3O/5sWgH4LnuQ11sPUxjBTCShYGz2b9WxLG3OBxi5Hjzl6T2Zkj5yGg1?=
 =?us-ascii?Q?mdLfvI+3umLnzd0zoeAttUQ+OJofj4UDk9OEEZwzR/G3kUtgaBMic736e6ai?=
 =?us-ascii?Q?tTM935SXY/wi7VAK8SJkCMaXju37+G4TLCoVbtl87bWpcZ2XpRk3dyQrewdi?=
 =?us-ascii?Q?P8Uu0qc5MpzVR51bLzSrrPmBYXy9IJk+paWgqLoqx3ckxWcx+hgVYXBwwPaS?=
 =?us-ascii?Q?h1NgxYRi/+kzvVLGM/ilsE4rRzBeOLHmER2zKfWpDnh5hzD8ue64WUzxzWMs?=
 =?us-ascii?Q?CfcbFHze9gC7I37LM3lC0+gUDpLu1PLCdnfLg4maymJuK0IuvDtzOxTQSJ0m?=
 =?us-ascii?Q?uOjY1xF33aKB1qEpb4vWaZ+8SHwW5URYldy5AS92Lh0PQ3CkWSfFm1s5Rx1z?=
 =?us-ascii?Q?s98Kd0xGTswiBTnv/vcAF8vnwsBn2+OgApYq4aW0fQO7mh3dbVLP9PbOICN1?=
 =?us-ascii?Q?+CDVjQbNCG845bqO5K94S5gTbQN1rkAb2gldzc1HQQSuxEaDvRKubleJMWUp?=
 =?us-ascii?Q?p6DXq9/uO2CJSVzj9EC3dnQ3DI+QCTvD9Tvn+vqLURouTMm5jaTUEHkXAUsl?=
 =?us-ascii?Q?2Ec0t1ZP0CdJDiQ6PU6fWy8KZg1NBGlAbuIHKeXqfH2p+DNuOoEQB9TqQ9L9?=
 =?us-ascii?Q?5/xTEfT3ieC4Wg4ubt2MixQp2f7Sre9dfvLBB4euoA3INJOXvcbxlfGk80z4?=
 =?us-ascii?Q?YJ12aDayi18Uwl4JqjQDOeM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3736d355-3c52-4cd5-6ec4-08d9b94d0a63
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 06:44:38.8819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GlTFxtu8DT4wTo27dKOWcb9AWCXICkSckVJmhMpfw729ji6bqr/AQsXx47SiLNEx4DvTXKQRM7PQaIB2S0qmPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2735
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
/drivers/net/dsa/ocelot/felix_vsc9959.c:1627:13-20:
WARNING opportunity for kmemdup
/drivers/net/dsa/ocelot/felix_vsc9959.c:1506:16-23:
WARNING opportunity for kmemdup

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/dsa/ocelot/felix_vsc9959.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 9add86eda7e3..0076420308a7 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1503,12 +1503,10 @@ static int vsc9959_stream_table_add(struct ocelot *ocelot,
 	struct felix_stream *stream_entry;
 	int ret;
 
-	stream_entry = kzalloc(sizeof(*stream_entry), GFP_KERNEL);
+	stream_entry = kmemdup(stream, sizeof(*stream_entry), GFP_KERNEL);
 	if (!stream_entry)
 		return -ENOMEM;
 
-	memcpy(stream_entry, stream, sizeof(*stream_entry));
-
 	if (!stream->dummy) {
 		ret = vsc9959_mact_stream_set(ocelot, stream_entry, extack);
 		if (ret) {
@@ -1624,11 +1622,10 @@ static int vsc9959_psfp_sfi_list_add(struct ocelot *ocelot,
 	struct felix_stream_filter *sfi_entry;
 	int ret;
 
-	sfi_entry = kzalloc(sizeof(*sfi_entry), GFP_KERNEL);
+	sfi_entry = kmemdup(sfi, sizeof(*sfi_entry), GFP_KERNEL);
 	if (!sfi_entry)
 		return -ENOMEM;
 
-	memcpy(sfi_entry, sfi, sizeof(*sfi_entry));
 	refcount_set(&sfi_entry->refcount, 1);
 
 	ret = vsc9959_psfp_sfi_set(ocelot, sfi_entry);
-- 
2.17.1