Date:   Mon, 6 Dec 2021 23:06:04 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Alistair Francis <alistair23@gmail.com>
Cc:     Andreas Kemnade <andreas@kemnade.info>,
        Alistair Francis <alistair@alistair23.me>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        =?iso-8859-1?Q?Myl=E8ne?= Josserand 
        <mylene.josserand@bootlin.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5
 touchscreen
Message-ID: <Ya8H3AHRqeJj7IUr@google.com>
References: <20211202122021.43124-1-alistair@alistair23.me>
 <20211202122021.43124-2-alistair@alistair23.me>
 <20211204233233.6c55875c@aktux>
 <CAKmqyKPDROFkAFgSjSDeTfhtZsArn4BbON9tyb1qTb_QcV5=xg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKmqyKPDROFkAFgSjSDeTfhtZsArn4BbON9tyb1qTb_QcV5=xg@mail.gmail.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 08:46:50PM +1000, Alistair Francis wrote:
> On Sun, Dec 5, 2021 at 8:32 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > Hi,
> >
> >
> > On Thu,  2 Dec 2021 22:20:18 +1000
> > Alistair Francis <alistair@alistair23.me> wrote:
> >
> > > From: Myl?ne Josserand <mylene.josserand@bootlin.com>
> > >
> > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> > > controllers. This driver supports only the I2C bus but it uses regmap
> > > so SPI support could be added later.
> > > The touchscreen can retrieve some defined zone that are handled as
> > > buttons (according to the hardware). That is why it handles
> > > button and multitouch events.
> > >
> > > Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > Signed-off-by: Myl?ne Josserand <mylene.josserand@bootlin.com>
> > > Message-Id: <20180703094309.18514-2-mylene.josserand@bootlin.com>
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> >
> > I finally got it working. The order of initialisation is important.
> > Params are copied on input_mt_init_slots() from ABS_MT* to ABS_*, so you
> > have to set params first.
> >
> > Here is the patch i need on top of this one to make it actually work
> > with X (evdev and libinput is tested):
> >
> > diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> > index b5d96eb71e46..3894ec85a732 100644
> > --- a/drivers/input/touchscreen/cyttsp5.c
> > +++ b/drivers/input/touchscreen/cyttsp5.c
> > @@ -415,19 +415,12 @@ static int cyttsp5_setup_input_device(struct device *dev)
> >         int max_x_tmp, max_y_tmp;
> >         int error;
> >
> > -       __set_bit(EV_REL, ts->input->evbit);
> 
> Does it work with this still included? I need this for my userspace program.

You need to fix your program, the kernel should not be declaring
capabilities that the device does not support.

Thanks.

-- 
Dmitry