Date:   Mon, 6 Dec 2021 23:23:19 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     linux-input@vger.kernel.org, patches@opensource.cirrus.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ff-core - Correct magnitude setting for rumble
 compatibility
Message-ID: <Ya8L5x7cL5GKmL0y@google.com>
References: <20211130135039.13726-1-ckeepax@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211130135039.13726-1-ckeepax@opensource.cirrus.com>
Precedence: bulk

On Tue, Nov 30, 2021 at 01:50:39PM +0000, Charles Keepax wrote:
> When converting a rumble into a periodic effect, for compatibility,
> the magnitude is effectively calculated using:
> 
> magnitude = max(strong_rubble / 3 + weak_rubble / 6, 0x7fff);
> 
> The rumble magnitudes are both u16 and the resulting magnitude is
> s16. The max is presumably an attempt to limit the result of the
> calculation to the maximum possible magnitude for the s16 result,
> and thus should be a min.
> 
> However in the case of strong = weak = 0xffff, the result of the first
> part of the calculation is 0x7fff, meaning that the min would be
> redundant anyway, so simply remove the current max.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Applied, thank you.

-- 
Dmitry