MIME-Version: 1.0
References: <20210621070058.37682-1-mie@igel.co.jp> <ed4de030-e0b3-503f-f0dc-75b103769dfc@ti.com>
In-Reply-To: <ed4de030-e0b3-503f-f0dc-75b103769dfc@ti.com>
From:   Shunsuke Mie <mie@igel.co.jp>
Date:   Tue, 7 Dec 2021 16:44:05 +0900
Message-ID: <CANXvt5r-1+W91DXNcVuRxTE0_T0TSGuduMhOfmYgY=N87uzqCg@mail.gmail.com>
Subject: Re: [PATCH] PCI: endpoint: Fix use after free in pci_epf_remove_cfs()
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Kishon,

2021=E5=B9=B412=E6=9C=887=E6=97=A5(=E7=81=AB) 16:26 Kishon Vijay Abraham I =
<kishon@ti.com>:
>
> Hi Shunsuke,
>
> On 21/06/21 12:30 pm, Shunsuke Mie wrote:
> > All of entries are freed in a loop, however, the freed entry is accesse=
d
> > by list_del() after the loop.
> >
> > When epf driver that includes pci-epf-test unload, the pci_epf_remove_c=
fs()
> > is called, and occurred the use after free. Therefore, kernel panics
> > randomly after or while the module unloading.
> >
> > I tested this patch with r8a77951-Salvator-xs boards.
>
> Can you provide the crash dump?
Ok. However, that is use-after-free bug. so, the crash log is changed rando=
mly.
I'll send some crash dumps.
> >
> > Fixes: ef1433f ("PCI: endpoint: Create configfs entry for each pci_epf_=
device_id table entry")
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> > ---
> >  drivers/pci/endpoint/pci-epf-core.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint=
/pci-epf-core.c
> > index e9289d10f822..538e902b0ba6 100644
> > --- a/drivers/pci/endpoint/pci-epf-core.c
> > +++ b/drivers/pci/endpoint/pci-epf-core.c
> > @@ -202,8 +202,10 @@ static void pci_epf_remove_cfs(struct pci_epf_driv=
er *driver)
> >               return;
> >
> >       mutex_lock(&pci_epf_mutex);
> > -     list_for_each_entry_safe(group, tmp, &driver->epf_group, group_en=
try)
> > +     list_for_each_entry_safe(group, tmp, &driver->epf_group, group_en=
try) {
> > +             list_del(&group->group_entry);
>
> Need full crash dump to see if this is really required or not. Ideally th=
is
> should be handled by configfs (or a configfs API could be used).
>
> Thanks,
> Kishon