Date:   Tue, 7 Dec 2021 09:18:21 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
        robh+dt@kernel.org, perex@perex.cz, jonathanh@nvidia.com,
        digetx@gmail.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets
Message-ID: <Ya8YzUdUg+bFcx/2@orome.fritz.box>
References: <1638858770-22594-1-git-send-email-spujar@nvidia.com>
 <1638858770-22594-3-git-send-email-spujar@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="IpL2ISpQCYw3FiPf"
Content-Disposition: inline
In-Reply-To: <1638858770-22594-3-git-send-email-spujar@nvidia.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--IpL2ISpQCYw3FiPf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 07, 2021 at 12:02:49PM +0530, Sameer Pujar wrote:
> Tegra194 HDA has only two resets unlike the previous generations of
> Tegra SoCs. Hence update the reset list accordingly.
>=20
> Fixes: 2d8f8955fe02 ("dt-bindings: tegra: Convert HDA doc to json-schema")
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
>  .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml       | 13 +++++++=
++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.y=
aml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index b55775e..70dbdff5 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -50,13 +50,18 @@ properties:
>        - const: hda2codec_2x
> =20
>    resets:
> +    minItems: 2
>      maxItems: 3
> =20
>    reset-names:
> -    items:
> -      - const: hda
> -      - const: hda2hdmi
> -      - const: hda2codec_2x
> +    oneOf:
> +      - items:
> +          - const: hda
> +          - const: hda2hdmi
> +          - const: hda2codec_2x
> +      - items:
> +          - const: hda
> +          - const: hda2hdmi

We could make this more specific using an if: conditional and match on
nvidia,tegra194-hda, but this would work as well, especially since I
presume that Tegra194's successors will also not have the hda2codec_2x
reset.

Acked-by: Thierry Reding <treding@nvidia.com>

--IpL2ISpQCYw3FiPf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmGvGM0ACgkQ3SOs138+
s6HtrA//SQTJKoBonjblOXCfZCGpl4NiEuG+ksgtRENQH8uNYgFqFryy5n2X7VAL
QVBUOOJfRyW4RHy6+dfw7QIG8d6c7JhTZuB9f5I6P+l27UQ4QG8p4kc5wQ8oi47R
uTRhlfl8qnjJmmtsgqMXcSWkAFlOqWxzSWiyY6CSmrbx27tcbEyaRudtfY1oe05N
aKN56OGVYimjF3yTU6iv7scGgBJ9o+FGNIM9dUZsPWfkuxdpIESRUJ4pQ2QVoQDh
Kv/ykUPHnLhS62pDvctKOYjFyDsPkEww8mZra+rnIYg93vHzW9xaVF2UcAmpW3Ie
H+JGFZ33eixMpCzyqG7NjtOXxOp6ardsYbf56VTUgig2JMDwszKDHtWkfDcJpcC2
3UylGgNUo/wQuUnqVL3BHQdi9i5I9w81ZC8XlJEmGyBhR46oLGDSUjwxZuiKuaiT
hOQm62icc8QSiBb0AF4q0NRiO6kxGSFDITCSR3ZPTBnems4kn7+hgMpNYDFVQq3h
Tui2E/Hx5X0Yuv3Pn2VHzEPTOSB/Vo9i4hFAHWcYjJgZfnAsC3XRAoAVPPXlqUPu
PLQphJUdXvsKris2OJDhbUJIz8kThuzbTiNgiH1QKCHukn+pbWuyyE5qS30L0dKZ
3I5YoTjE79X+fDDtIeEbJcwZbKelyx6QgduhREVvNMs9Jk8s7QU=
=m28v
-----END PGP SIGNATURE-----

--IpL2ISpQCYw3FiPf--