From:   =?iso-8859-1?Q?Christian_L=F6hle?= <CLoehle@hyperstone.com>
To:     Nishad Kamdar <nishadkamdar@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Jens Axboe <axboe@kernel.dk>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Avri Altman <avri.altman@wdc.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Huijin Park <huijin.park@samsung.com>,
        Yue Hu <huyue2@yulong.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: Add support for the eMMC RTC feature in
 mmc_ops
Thread-Topic: [PATCH] mmc: core: Add support for the eMMC RTC feature in
 mmc_ops
Thread-Index: AQHX6gvXWeR51ae/h0Scepl+xaO8nawlJez1
Date:   Tue, 7 Dec 2021 08:52:40 +0000
Message-ID: <cc8415c87d894a59af20d6057d9eb650@hyperstone.com>
References: <20211205191009.32454-1-nishadkamdar@gmail.com>
In-Reply-To: <20211205191009.32454-1-nishadkamdar@gmail.com>
Accept-Language: en-US, de-DE
Content-Language: en-US
Content-Type: text/plain;
        charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

>There is no way however, to read the RTC time from the
>device. Hence we rely on the response of the CMD49 to
>confirm the completion of the operation.

The spec does not mention anything special about error cases where the device can reject CMD49,
if you want some meaningful possibility of this anyway you should get the R1 of the command following on the CMD49, though,
as the raised error would likely be of detection mechanism type X, see table 68.
IMO it would likely only be bit 19 ("ERROR"), but maybe try it with some cards.
So CMD49->CMD13 would be an option.
You could also check if and how some cards reject CMD49 by e.g. setting 
Regards,
Christian

From: Nishad Kamdar <nishadkamdar@gmail.com>
Sent: Sunday, December 5, 2021 8:10 PM
To: Ulf Hansson; Jens Axboe; Adrian Hunter; Bean Huo; Shawn Lin; Avri Altman; Stephen Boyd; Huijin Park; Yue Hu; Wolfram Sang
Cc: Nishad Kamdar; Greg Kroah-Hartman; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] mmc: core: Add support for the eMMC RTC feature in mmc_ops
?   
This patch adds support to set the RTC information in
the eMMC device. This is based on the JEDEC specification.

There is no way however, to read the RTC time from the
device. Hence we rely on the response of the CMD49 to
confirm the completion of the operation.

This patch has been tested successfully with the ioctl
interface. This patch has also been tested suceessfully
with all the three RTC_INFO_TYPEs.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
?drivers/mmc/core/mmc_ops.c | 59 ++++++++++++++++++++++++++++++++++++++
?drivers/mmc/core/mmc_ops.h |? 2 ++
?include/linux/mmc/mmc.h??? |? 1 +
?3 files changed, 62 insertions(+)

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index d63d1c735335..490372341b3b 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -1063,3 +1063,62 @@ int mmc_sanitize(struct mmc_card *card, unsigned int timeout_ms)
???????? return err;
?}
?EXPORT_SYMBOL_GPL(mmc_sanitize);
+
+int mmc_set_time(struct mmc_card *card, struct mmc_host *host,
+??????????????? u8 rtc_info_type, u64 seconds)
+{
+?????? struct mmc_request mrq = {};
+?????? struct mmc_command cmd = {};
+?????? struct mmc_data data = {};
+?????? struct scatterlist sg;
+?????? int err = 0;
+?????? u8 *data_buf;
+
+?????? data_buf = kzalloc(512, GFP_KERNEL);
+?????? if (!data_buf)
+?????????????? return -ENOMEM;
+
+?????? if (rtc_info_type == 0x01 || rtc_info_type == 0x02 ||
+?????????? rtc_info_type == 0x03) {
+?????????????? data_buf[0] = 0x01;
+?????????????? data_buf[1] = rtc_info_type;
+?????????????? memcpy(&data_buf[2], &seconds, sizeof(u64));
+?????? } else {
+?????????????? pr_err("%s: invalid rtc_info_type %d\n",
+????????????????????? mmc_hostname(host), rtc_info_type);
+?????????????? kfree(data_buf);
+?????????????? return -EINVAL;
+?????? }
+
+?????? mrq.cmd = &cmd;
+?????? mrq.data = &data;
+
+?????? cmd.opcode = MMC_SET_TIME;
+?????? cmd.arg = 0;
+?????? cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_ADTC;
+
+?????? data.blksz = 512;
+?????? data.blocks = 1;
+?????? data.flags = MMC_DATA_WRITE;
+?????? data.sg = &sg;
+?????? data.sg_len = 1;
+?????? sg_init_one(&sg, data_buf, 512);
+
+?????? mmc_set_data_timeout(&data, card);
+
+?????? mmc_wait_for_req(host, &mrq);
+
+?????? if (cmd.error) {
+?????????????? err = cmd.error;
+?????????????? goto out;
+?????? }
+
+?????? if (data.error) {
+?????????????? err = data.error;
+?????????????? goto out;
+?????? }
+out:
+?????? kfree(data_buf);
+?????? return err;
+}
+EXPORT_SYMBOL_GPL(mmc_set_time);
diff --git a/drivers/mmc/core/mmc_ops.h b/drivers/mmc/core/mmc_ops.h
index 9c813b851d0b..0c8695d1b363 100644
--- a/drivers/mmc/core/mmc_ops.h
+++ b/drivers/mmc/core/mmc_ops.h
@@ -55,6 +55,8 @@ void mmc_run_bkops(struct mmc_card *card);
?int mmc_cmdq_enable(struct mmc_card *card);
?int mmc_cmdq_disable(struct mmc_card *card);
?int mmc_sanitize(struct mmc_card *card, unsigned int timeout_ms);
+int mmc_set_time(struct mmc_card *card, struct mmc_host *host,
+??????????????? u8 rtc_info_type, u64 seconds);
?
?#endif
?
diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
index d9a65c6a8816..52a3bf873d50 100644
--- a/include/linux/mmc/mmc.h
+++ b/include/linux/mmc/mmc.h
@@ -64,6 +64,7 @@
?#define MMC_WRITE_MULTIPLE_BLOCK 25?? /* adtc??????????????????? R1? */
?#define MMC_PROGRAM_CID????????? 26?? /* adtc??????????????????? R1? */
?#define MMC_PROGRAM_CSD????????? 27?? /* adtc??????????????????? R1? */
+#define MMC_SET_TIME??????????? 49?? /* adtc??????????????????? R1? */
?
?? /* class 6 */
?#define MMC_SET_WRITE_PROT?????? 28?? /* ac?? [31:0] data addr?? R1b */
-- 
2.17.1

    =
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782