Date:   Tue, 7 Dec 2021 10:51:04 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nishad Kamdar <nishadkamdar@gmail.com>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Jens Axboe <axboe@kernel.dk>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Huijin Park <huijin.park@samsung.com>,
        Yue Hu <huyue2@yulong.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Christian =?iso-8859-1?Q?L=F6hle?= <CLoehle@hyperstone.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: Add support for the eMMC RTC feature in
 mmc_ops
Message-ID: <Ya8uiOq3MGGKRB5n@kroah.com>
References: <20211205191009.32454-1-nishadkamdar@gmail.com>
 <DM6PR04MB657527FCF325EA9760032DA5FC6E9@DM6PR04MB6575.namprd04.prod.outlook.com>
 <20211207093009.GA11794@nishad>
 <DM6PR04MB6575BF4FC2DE49885D0EEDF0FC6E9@DM6PR04MB6575.namprd04.prod.outlook.com>
 <20211207094304.GA11969@nishad>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211207094304.GA11969@nishad>
Precedence: bulk

On Tue, Dec 07, 2021 at 03:13:08PM +0530, Nishad Kamdar wrote:
> On Tue, Dec 07, 2021 at 09:33:46AM +0000, Avri Altman wrote:
> > > On Tue, Dec 07, 2021 at 08:28:42AM +0000, Avri Altman wrote:
> > > >
> > > > > This patch adds support to set the RTC information in the eMMC
> > > > > device. This is based on the JEDEC specification.
> > > > >
> > > > > There is no way however, to read the RTC time from the device. Hence
> > > > > we rely on the response of the CMD49 to confirm the completion of
> > > > > the operation.
> > > > >
> > > > > This patch has been tested successfully with the ioctl interface.
> > > > > This patch has also been tested suceessfully with all the three
> > > > > RTC_INFO_TYPEs.
> > > > If this is triggered from user-space via ioctl anyway, Why do we need
> > > > this command to be implemented in the kernel?
> > > > Why not just add this to mmc-utils?
> > > >
> > > > Thanks,
> > > > Avri
> > > As per the spec, B51: Section 6.6.35:
> > > Providing RTC info may be useful for internal maintainance operations.
> > > And the host should send it on the following events:
> > > - power-up
> > > - wake-up
> > > - Periodically
> > > Hence IMO, the Kernel would be the right place of peforming this operation.
> > But your patch doesn't do that, is it?
> >
> Yes, That's because this operation may be device specific. In order to know when
> to call this function may require eMMC firmware info.
> This patch only adds support so that if the info is made available
> in the future, a separate patch can be added to introduce the calling mechanism.

We do not add code that is not actually used in the kernel tree.

Please submit a user of this new function, otherwise there is no need
for it at all.

thanks,

greg k-h