From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to
 napi_build_skb()
Thread-Topic: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to
 napi_build_skb()
Thread-Index: AQHX4I+ZjyMyG4uYF0GCApeNGAelw6wm4gEA
Date:   Tue, 7 Dec 2021 10:03:17 +0000
Message-ID: <SN6PR11MB3374B42800E486F22C49067BFC6E9@SN6PR11MB3374.namprd11.prod.outlook.com>
References: <20211123171840.157471-1-alexandr.lobakin@intel.com>
 <20211123171840.157471-6-alexandr.lobakin@intel.com>
In-Reply-To: <20211123171840.157471-6-alexandr.lobakin@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mZ1oJT9XEhkaVgbOXrI7d1zL4ReWE1xoyLpZswOZlCKeH9yPeFLKHD29LmRs?=
 =?us-ascii?Q?lD565RYiJ2gpvwAsxuvDq4hQiRYWmxds8ZhhCagsn52pKtBsB7SyjkuhGf3d?=
 =?us-ascii?Q?6UqpR8H1vWFG9OcWvK8d0DHPyW/BcfHQWoHAwIjsCOyw0qdj/wA8qWMO0++E?=
 =?us-ascii?Q?F7mm+/FBwkKLKTb/PF7KY25Fiw4X/pCj3alEOJlSF4pEX3FJzB/8zLMHSxdM?=
 =?us-ascii?Q?VjawaQZrrl0Za+yE5ry1VeQgGEhxpakCrsXT7peEdKeukLF2eBM2K6+isg1t?=
 =?us-ascii?Q?csh+BYvmnAKMLFYGiSJlZhUCHycc94/o1+dNecyfOSlz2/IwoP+dia/SUCaY?=
 =?us-ascii?Q?lh5+jmJMR0sxL5igOnRXmhCy1Bag7/abzWKMe2V4mtd/k9Z7b0nHp4CjaCeM?=
 =?us-ascii?Q?5rHczQkcVqPlMtKJJx1rjKegopjiF8oS4JKKn5xERe0ut+NJxJyCr7/FRz2L?=
 =?us-ascii?Q?WXlmJknTDUEOO6mc9YEQGNs3UviirOzBBpJlENw30DcdKDjR3/i2w1rKDCbM?=
 =?us-ascii?Q?fl615aJaoEKCr18hulo1Hiaf1yBxWbiI+xfmmHZdMyki0DkhJwxpmyi4PEM1?=
 =?us-ascii?Q?nbrNMuTMEvL3zCQjdoxubdd/jM3CWk8jmZ8ISImrx8qyWmtFbbG2QzbcF6+M?=
 =?us-ascii?Q?CadytGuIeJvSqGDQq9MWbaTdvtKudAXERc84IgO4guLDb86Nno6Q418tVH81?=
 =?us-ascii?Q?RQ4iiqm4QKrdsTyCy+djxJlRHcnnbfodk+66ZZKTFUv85bTlRVxMFfTa3kvJ?=
 =?us-ascii?Q?8nqkGQMqhi86vDXT9Moqfe8/wu+h9tETpRlhnyPTMT61OLtbFkwEDQBdieOo?=
 =?us-ascii?Q?/3McQ0tfzN4leQrQ6NgK/fu+Rb9cKk7Tj1Esbh3XvvavEF5EdIvSvH62odNE?=
 =?us-ascii?Q?j9fcqidxgbqvNI+BzMCdHeXowWuzxRog8r/IRinROwwcgXIHvPChTaYnGVRc?=
 =?us-ascii?Q?S08E0rY+GK5jElRa4vrmj5ZYnsClvwgBLQ2mdzKRGcb005MbwCtfJORg60m6?=
 =?us-ascii?Q?uH5XNr4LMTaDH9sfTAOw1RaEyiw+bXVCdvnqiVbmY5gMCCY4N6d2Hf5pSIWm?=
 =?us-ascii?Q?8UycZ/CED3zc0WuWnBCxtUQEwJo9KwD7dapBoYPPCF87SjdlvuJN6SoNJe4W?=
 =?us-ascii?Q?zwqskuSQG7EoDUkrQxTx5RvdwWOwuCr/BzyHvSWUH9VSyC8Sfek6WwXzWYgO?=
 =?us-ascii?Q?4iXrAL94muI5ynKlqfY+G/ICtGmQ8iTDUr21aq1lQaGsRCblTs1oV3XJba5B?=
 =?us-ascii?Q?8UqBWj7WV7uIbjhgj3TWKq92PQNDQWdyNRVrRj1nhu+D8TlqfgUKBD9/Q4KT?=
 =?us-ascii?Q?LyLL8HUk+d3oHl02OlWEdzDgbX5IS3Zi+PpTms4e9UHJj9jSAaBggrzsATcy?=
 =?us-ascii?Q?h4EOkjZYZFCBvJMilpSfzhyq45xVUB6epTXE7cnZzsi25HZcVT1YN3EYYYp1?=
 =?us-ascii?Q?MNUZ2lZB0gDG4ZkjVCsh2MjogoKvS1FXKRTleKrP6IfKVTZ/r+Y6r78W6prC?=
 =?us-ascii?Q?3FamOy/4pKy16S3xLIiXAHvjyDlpTYx9L2/U/Cydcl+Gv8jpgkmyhkXUux+X?=
 =?us-ascii?Q?lXrYxbCy2T+Bf6Zz4EMgRcKhELf69ULzD9R+PJqhWDb20trz0RT+XXcvfhEZ?=
 =?us-ascii?Q?9Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3374.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0562021c-4c9e-4678-fb64-08d9b968ca93
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2021 10:03:17.4959
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0iKNSmw+LryA7tbd5pSgaKTUuKW9RpjijunkLaCqTS3PUocr0JLHiJYYden+Fe5X77VdkXIbfT8EkXf6Fly8hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3119
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Tuesday, November 23, 2021 10:49 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to napi_build=
_skb()
>=20
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save s=
ome
> cycles on freeing/allocating skbuff_heads on every new Rx or completed Tx=
.
> ice driver runs Tx completion polling cycle right before the Rx one and u=
ses
> napi_consume_skb() to feed the cache with skbuff_heads of completed entri=
es,
> so it's never empty and always warm at that moment. Switch to the
> napi_build_skb() to relax mm pressure on heavy Rx.
>=20
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)