Message-ID: <dc7d43b96cd1a40654bb2da009ea515b8ded40c3.camel@sipsolutions.net>
Subject: Re: [PATCH 1/3] iwlwifi: fix LED dependencies
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Arnd Bergmann <arnd@kernel.org>, Stanislaw Gruszka <stf_xl@wp.pl>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Luca Coelho <luciano.coelho@intel.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Ayala Beker <ayala.beker@intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 07 Dec 2021 11:49:18 +0100
In-Reply-To: <fd1f5c0f0a9a6b3f59ed0d03e963f87bf745705f.camel@sipsolutions.net>
References: <20211204173848.873293-1-arnd@kernel.org>
         <c9acebcef9504ac6889de25d528c3ea0c590b1c1.camel@sipsolutions.net>
         <fd1f5c0f0a9a6b3f59ed0d03e963f87bf745705f.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-12-07 at 11:16 +0100, Johannes Berg wrote:
> On Tue, 2021-12-07 at 11:14 +0100, Johannes Berg wrote:
> > On Sat, 2021-12-04 at 18:38 +0100, Arnd Bergmann wrote:
> > >  
> > >  config IWLWIFI_LEDS
> > >  	bool
> > > -	depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
> > > +	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> > > 
> > 
> > Hm. Can we really not have this if LEDS_CLASS=n?
> > 
> 
> Well, umm. That wouldn't make sense for IWLWIFI_LEDS, sorry.
> 
> Might be simpler to express this as "depends on MAC80211_LEDS" which has
> the same condition, and it feels like that makes more sense than
> referencing MAC80211 here?
> 

Hm, maybe not. Sorry for the monologue here - but MAC80211_LEDS is user
selectable, and so I guess that's a different thing.

johannes