Subject: Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices
To:     Dmitry Osipenko <digetx@gmail.com>, tiwai@suse.com,
        broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org,
        thierry.reding@gmail.com, perex@perex.cz
Cc:     jonathanh@nvidia.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Mohan Kumar <mkumard@nvidia.com>
References: <1638858770-22594-1-git-send-email-spujar@nvidia.com>
 <1638858770-22594-2-git-send-email-spujar@nvidia.com>
 <7742adae-cdbe-a9ea-2cef-f63363298d73@gmail.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <8fd704d9-43ce-e34a-a3c0-b48381ef0cd8@nvidia.com>
Date:   Tue, 7 Dec 2021 17:30:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <7742adae-cdbe-a9ea-2cef-f63363298d73@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnBPaWpoamRCQkRNMmNOdGFtdFF5ajMrT1NLZDNDWVhDSnVyMkVObzM1QWZi?=
 =?utf-8?B?MFhoVVlJdGpFcG1JdGVNYWNnQjhtNDk4YXQ5WVlJODRWYUN5NW10enphVXZ0?=
 =?utf-8?B?NDkzTWpSZDlveDBTZ2V3R3ovZm02V1h3a0VFdHJUSUJHeWxxeDRMd2k2RnI4?=
 =?utf-8?B?bVljRENvTWRMMGhHU2tTQTZ0STdmdW1xdWY1dlNhTjByTzNmeXE2elRWdklX?=
 =?utf-8?B?QjJPZzFDM3VTb2RLSklxbThlbzFVb3JnOTlSU2hvTnpTc1F4b0c4bWpWZ3FQ?=
 =?utf-8?B?ODVuYW5tL3p6QVRZY2tsSDF2VHczdHZyeDNmd0NuQkJ1VXdqS0Rnak5pVWdv?=
 =?utf-8?B?USs1Sm5DYkYyenJrdEtuWUs0S3dLemJ3REdGRUZpSms4amJDRGhjTjNKYnlx?=
 =?utf-8?B?WmVNVzlnS0Z0TkFuZmIwOC94N2FMa1hmbVNndDZmQkZxb2VxZmZreGxqdW9x?=
 =?utf-8?B?TnVJNlNPRlVFVXZ3VWJPSDBqb0FIRXJUT290QVlkTmxXNVlBMWZpKy9GQUMy?=
 =?utf-8?B?elZVVDZpZkR5b3JXNC81bUdJdk1yWkdpbmJUaVd6b2lnRmh2bkk2TTFQbkNN?=
 =?utf-8?B?ME9TOFQrL09OT28yZ1kwUTViM3BiZFRpK3YvVjJqb0l2THZQeEtYMnNON25Z?=
 =?utf-8?B?Wm54VUZrcDVCZXo1T2s4SzdzaUR1VVZRcTlDa053NnBFaFZTSnN0R2hLdUdu?=
 =?utf-8?B?MWRMK2Jka00xeFBzMGdsbHBsNll1ekxEV3BNNzR6MVdKZ0FMWHp0b0FtQ2s3?=
 =?utf-8?B?NzVubzZMQ0VCaUo0endLQU9nL2FQVEh4WnM4MU9VY1BOZG51TU9hMjRCMXhu?=
 =?utf-8?B?eFYwMTc1eHROd1hmU3N6TkdOcWRyd25hbFNMbVRCZHRDNXRCUlNJY0lrK2NE?=
 =?utf-8?B?emNsM3NDVWVkVkxRbjdrcGhlYVM3WGQ1eDZRdERPd3hnVTFFbUplSGxRR2FY?=
 =?utf-8?B?NkI5VCtVbXV2d2ZSWWhWcDFvNkhpNzNmUEl3cUZkL3ZjSGo5b1hkblFqTTVR?=
 =?utf-8?B?YlNGT1daKzBYTTNJS1JTMzFrNUU5WVpoZGhVUURzc3I0SjNPaENQRFlCZG5M?=
 =?utf-8?B?MXoyb0hqZ0lkeFBrc01RZ1ZFQ3U5ZTZ6M2lCTGx2TTFYWllpOERhL2h4eTh3?=
 =?utf-8?B?UHo0RzgwVGRIeVRVRVF4ZCtlNm9QVjR3cUtTVlFIZ3NOd044ZWtGU3JiSXc2?=
 =?utf-8?B?ZHphODhYMHl6QjlZQzNTeDdMZnY5MmtLWnF5V1haSElKQVV3RW1QUHhQRmda?=
 =?utf-8?B?d1hPRVprTXNaSkZ0K2hTTCtzRThyYkhQM0MvSlA5cDlrMU5sd3g3MGh0RDNP?=
 =?utf-8?B?S3pTdTB0aStBdFN4Y2dBeTlmTnFyNnRmN0NiUjcxRGZ1TjZsQXhRMzJ2UDV5?=
 =?utf-8?B?dTVmQ1BmRFhsYko0YU5ZYTVSTktzK0xONDFmWGpURnY1ZmpVL1hUUFFUbERP?=
 =?utf-8?B?ZHBQc2Z4dU1Kc2hmT2thQks0ME1SNEhnYUNaS2NoWHpReWpQb3AvR1BidjM3?=
 =?utf-8?B?a0duSFRjRnF2dGpmTmVueitDL2JGZTFQSndJUHNwS1ZFOW04TW9zeG9zUFND?=
 =?utf-8?B?WlQyZzk2YXpPU3ZqaWNQdGtqNWREeHpyT1JmUHJ4dVJhSHpqZXFaQmtqSXd1?=
 =?utf-8?B?bmlubDFkTFR1NmJNclNEc3FxMGQwU0xVNzUzQjBMc0R3Wmp3TC9sdkFERmVR?=
 =?utf-8?B?WG0vb0ExdnVRd0NYaEhFeUNKVEU5ZmNtU2RQTVlKVTJsQVN3dWNuNG5RczVU?=
 =?utf-8?B?RjN1b1V6cm9qMHJVM0xDVEpOd0NRSHBnbm9jRyttMkQzNFNUbm1mdjNqY1FR?=
 =?utf-8?B?b1VTUHFvN1RMNlVHMTBpUkpDeWk5NEhsajAxSDR6dTFsZkN0S044RHVyYmsv?=
 =?utf-8?B?Qy9FeURLVGJjaGt3LzF0bU9iNVpMbFRoaUVabnZGZCs0bGZseWxPYnN0SDVC?=
 =?utf-8?B?bHJQRldYYWRPdXFpSWZ2WldObXFZS1RDR2gvU1RPRS9QeG94SXNyWHRIaHU1?=
 =?utf-8?B?VmNLS20zalJ5aDdVanBYTDNkRmJoOENlSEljOVJjb3phaHlJVTdZZ2VRQWxa?=
 =?utf-8?B?eGtNUjNBTlVTMUZyOHFORHE5dXFaekVUNkM5VzJjMWhsOTNLanNiNURCaFBZ?=
 =?utf-8?B?akpHakNmajlORzJFS1NVenNNYWQ0ZHZXUGI5SVUzUkRMNjQ4amVRUzRqQzhJ?=
 =?utf-8?Q?W9dR8930iJ/P8IrSEjW+baQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3847956-79b7-4d3a-8523-08d9b9793b02
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1576.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 12:00:58.3327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbbi0EsXdNIlUQaIdM0GTnWOB5pmfc53Nx4kzrenRfwxkN9GN8kXvWfJR3Rk5Q1cl/6bFpJEEVKhxlzYKhG4zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0085
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/7/2021 3:52 PM, Dmitry Osipenko wrote:
> 07.12.2021 09:32, Sameer Pujar пишет:
>> HDA regression is recently reported on Tegra194 based platforms.
>> This happens because "hda2codec_2x" reset does not really exist
>> in Tegra194 and it causes probe failure. All the HDA based audio
>> tests fail at the moment. This underlying issue is exposed by
>> commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
>> response") which now checks return code of BPMP command response.
>>
>> The failure can be fixed by avoiding above reset in the driver,
>> but the explicit reset is not necessary for Tegra devices which
>> depend on BPMP. On such devices, BPMP ensures reset application
>> during unpowergate calls. Hence skip reset on these devices
>> which is applicable for Tegra186 and later.
> The power domain is shared with the display, AFAICS. The point of reset
> is to bring h/w into predictable state. It doesn't make sense to me to
> skip the reset.

Yes the power-domain is shared with display. As mentioned above, 
explicit reset in driver is not really necessary since BPMP is already 
doing it during unpowergate stage. So the h/w is already ensured to be 
in a good state.