From:   Qing Wang <wangqing@vivo.com>
To:     JC Kuo <jckuo@nvidia.com>, Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] phy: tegra: add missing put_device() call in tegra210_xusb_padctl_probe()
Date:   Tue,  7 Dec 2021 04:56:15 -0800
Message-Id: <1638881776-3308-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kEMQlqy2bkSpiRGbLIFsuIWfClBlJ+ehMyBApaJbqjqrxFvRgcmraQPDP54k?=
 =?us-ascii?Q?mI+68n2pF+Sp8R72Y9Xycz//1qLXGq9miB3e7J/DgLMLj9+kOiO/Hfo7zgku?=
 =?us-ascii?Q?qXXAUpiEcgpLLiStLY+lUxp2qeHZEBCzIS6BzYYnIzAs2ntsuuUMATMcSYt1?=
 =?us-ascii?Q?DyQgafzX5JHYS5PYhrckjDYbQiAFM1muz1i4XhKakcvLi5IhneeTsslKU5sJ?=
 =?us-ascii?Q?PfSx8hDD+YPVzLASyIe4ZLioHWcGNF3ZKqBgBybKQUySGt5hgD0MoR4KguhT?=
 =?us-ascii?Q?vTnP5I3Qu4lEdWX5Tu3o8wFZNEw+wEcm3lhzGsDUF1fLVB7y7Hzz8tJ9sHiQ?=
 =?us-ascii?Q?t3pOT8yiFhE6U0N0DvACubLysnjPYQkYvWB51Xw5xWWImPTqK1Ae5NECixqS?=
 =?us-ascii?Q?dX6IW7h3uK/bSQAmPSrQhp7AqM+4jWchcEW5gDvHxMG3hUhCD2YvWsAQ7Y9a?=
 =?us-ascii?Q?0u2MbBKAdiYyvjnVn44+yPtvZ4EEuhFWdxVU0UkEcJgSq3ht/gc21Ab8SzQI?=
 =?us-ascii?Q?v7ewm3Oge3FfzTZlBNcUFhwL/49S6HeEHyQFdachN95liYHQZFk+zQhYkGxt?=
 =?us-ascii?Q?JK8k8WZbIvpfmhGLVpXlMi0mRWnbSGGMwG6SCFK5OaGlAxyeN8gNmOW5hx8B?=
 =?us-ascii?Q?knaJOkzkbK4FTZWvHNANGkHpkhp6a5bBvyROE9lF6RqhJV5lh7i+bxPFfJsp?=
 =?us-ascii?Q?jYWIVvnVcHG78GfmEhXke3czWA855OkpIQaEoS5i4EM2yYcPNR9k+lXukZzf?=
 =?us-ascii?Q?v+o7FLt4Eu9NrL5OqxS67W8tBlcpc+46mRYHMDxM7QACtLDGqGGKbuoWDNDG?=
 =?us-ascii?Q?Xin387QzDoxaPlTbpl+KS3JbuKGG6YPafZEiG9/mK4L/mh47p/htUVqwXaQp?=
 =?us-ascii?Q?MAxMX8CxgxclWe/5tKePFpAqJzTR7uwlzf1SweA3e3YueCM3IaibTLoqT8LH?=
 =?us-ascii?Q?yPaAfGMBAA6kkXuLVXtGU40Jj07zLGSkNWHI2SBX3enP9ny//4AoDsKVCSAE?=
 =?us-ascii?Q?GaZokWNGJIkNVzfNgZeXYLqgvCQOcA0mytvhYH+J/AAIdbVyW9CsuVOwBaqF?=
 =?us-ascii?Q?Op6z89pEz1ASNh+H7r/OXmGrv6v2TsWoNwGQ/xN69AU2tbx2D20TWcTE7eX9?=
 =?us-ascii?Q?qmBTnYXFJB011Yemu5IH8NzzujjpeTzaktUuCWeY0lOBYD6Ogi+A60hBey6V?=
 =?us-ascii?Q?+pGsoxAgDUAuyOnNfzAirKR1TSmRyTbsBqQyJbbpllBzQOdKO5r8SskdfeDU?=
 =?us-ascii?Q?8bQpv7Cn/oroNhCU4XdZ7if9zGZYIJHElANjyZ9dLSgD9J4tPEuVB7zd7YOs?=
 =?us-ascii?Q?fTPYjsSbA9rU28PHLQEJmIos0NWFHl3s5+wrwy9QI0E2slHSL57Wu/jeTXJX?=
 =?us-ascii?Q?6S3hIn8s0Y91IhdRHZnz0CpPjcLg9GqHj0DAYX4/MJXJTmGESr/gc/BYA3BZ?=
 =?us-ascii?Q?Q9EuCzJs4rfvA4H/MdiAeaRCQMDYkNfK9oI2ofXic9PgnVgAscjpF/BVrpoW?=
 =?us-ascii?Q?uzUWP2CsdXEnZEB1eYoefDLpv44zngTmsIfPIiCNC7assDcUt3SJIdL2TgAI?=
 =?us-ascii?Q?gmCzymh/OviLR7Slpw/moNJLXqm6n1w90/dF0GmRe2lrHgbKmyq0BRtuEcFm?=
 =?us-ascii?Q?BRxpqLT1s/gJzr8lHT0YCX8=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15077235-3c6b-4f85-4454-08d9b980fb0e
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 12:56:27.0366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WxSkqal0u9Gbi7KX5xYVh9MRAasQm6w2TieeJFfMH/LUtkOXjxY2INK55FCRsWg1DrxXTSIuHvOIURdGmzNWzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3035
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

of_find_device_by_node() takes a reference to the embedded struct device 
which needs to be dropped when error return.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/phy/tegra/xusb-tegra210.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c
index eedfc7c..05a0800
--- a/drivers/phy/tegra/xusb-tegra210.c
+++ b/drivers/phy/tegra/xusb-tegra210.c
@@ -3170,8 +3170,10 @@ tegra210_xusb_padctl_probe(struct device *dev,
 		goto out;
 	}
 
-	if (!platform_get_drvdata(pdev))
+	if (!platform_get_drvdata(pdev)) {
+		put_device(&pdev->dev);
 		return ERR_PTR(-EPROBE_DEFER);
+	}
 
 	padctl->regmap = dev_get_regmap(&pdev->dev, "usb_sleepwalk");
 	if (!padctl->regmap)
-- 
2.7.4