Date:   Tue, 7 Dec 2021 14:06:47 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, Ameer Hamza <amhamza.mgc@gmail.com>,
        vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: initialize return variable on
 declaration
Message-ID: <20211207140647.6926a3e7@thinkpad>
In-Reply-To: <20211206162510.35b85e74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20211206113219.17640-1-amhamza.mgc@gmail.com>
        <Ya4OP+jQYd/UwiQK@lunn.ch>
        <20211206232953.065c0dc9@thinkpad>
        <20211206162510.35b85e74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 6 Dec 2021 16:25:10 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 6 Dec 2021 23:29:53 +0100 Marek Beh=C3=BAn wrote:
> > On Mon, 6 Dec 2021 14:21:03 +0100
> > Andrew Lunn <andrew@lunn.ch> wrote:
> >  =20
> > > On Mon, Dec 06, 2021 at 04:32:19PM +0500, Ameer Hamza wrote:   =20
> > > > Uninitialized err variable defined in mv88e6393x_serdes_power
> > > > function may cause undefined behaviour if it is called from
> > > > mv88e6xxx_serdes_power_down context.
> > > >=20
> > > > Addresses-Coverity: 1494644 ("Uninitialized scalar variable")
> > > >=20
> > > > Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
> > > > ---
> > > >  drivers/net/dsa/mv88e6xxx/serdes.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >=20
> > > > diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/m=
v88e6xxx/serdes.c
> > > > index 55273013bfb5..33727439724a 100644
> > > > --- a/drivers/net/dsa/mv88e6xxx/serdes.c
> > > > +++ b/drivers/net/dsa/mv88e6xxx/serdes.c
> > > > @@ -1507,7 +1507,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_=
chip *chip, int port, int lane,
> > > >  			    bool on)
> > > >  {
> > > >  	u8 cmode =3D chip->ports[port].cmode;
> > > > -	int err;
> > > > +	int err =3D 0;
> > > > =20
> > > >  	if (port !=3D 0 && port !=3D 9 && port !=3D 10)
> > > >  		return -EOPNOTSUPP;     =20
> > >=20
> > > Hi Marek
> > >=20
> > > This warning likely comes from cmode not being a SERDES mode, and that
> > > is not handles in the switch statementing. Do we want an
> > >=20
> > > default:
> > > 	err =3D EINVAL;
> > >=20
> > > ? =20
> >=20
> > currently all the .serdes_power() methods return 0 for non-serdes ports.
> > This is because the way it is written, these methods are not called if
> > there is not a serdes lane for a given port.
> >=20
> > For this issue with err variable undefined, to fix it we should simply
> > set int err=3D0 at the beginning of mv88e6393x_serdes_power(), to make =
it
> > behave like other serdes_power() methods do in serdes.c. =20
>=20
> Any objections to using a default case in the switch statement, tho?
> I agree with Andrew that default statement would make the reasoning
> clearer than just setting the variable at the start of the function.

No objection, just that it should be done for all the serdes_power()
methods in serdes.c.

Marek