MIME-Version: 1.0
References: <20211202063216.24439-1-zajec5@gmail.com> <CAL_JsqL=4iUJjQXjGc7eacbYW5YE-VRC4yGhu8pLVd-zUKvhHQ@mail.gmail.com>
 <c2afe6fe-d4d2-c9c3-eb36-90969a0b657d@gmail.com>
In-Reply-To: <c2afe6fe-d4d2-c9c3-eb36-90969a0b657d@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 7 Dec 2021 09:17:02 -0600
Message-ID: <CAL_JsqKzv4GLN8bmskKcA6HE+6nqDwOz=1oGW+z7r6joBFjKLA@mail.gmail.com>
Subject: Re: [PATCH REBASE] dt-bindings: pinctrl: use pinctrl.yaml
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        patches@opensource.cirrus.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Dec 7, 2021 at 2:47 AM Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> w=
rote:
>
> On 06.12.2021 23:50, Rob Herring wrote:
> > On Thu, Dec 2, 2021 at 12:32 AM Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.c=
om> wrote:
> >>
> >> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
> >>
> >> Also fix some examples to avoid warnings like:
> >> brcm,ns-pinmux.example.dt.yaml: pin-controller@1800c1c0: $nodename:0: =
'pin-controller@1800c1c0' does not match '^pinctrl|pinmux@[0-9a-f]+$'
> >
> > I think you missed some. linux-next now has these warnings:
>
> Oops, sorry, I think I didn't test MFD bindings *after* modifying
> pinctrl bindings.
>
>
> > /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/cirru=
s,madera.example.dt.yaml:
> > codec@1a: $nodename:0: 'codec@1a' does not match
> > '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> >  From schema: /builds/robherring/linux-dt/Documentation/devicetree/bind=
ings/mfd/cirrus,madera.yaml
>
> I'm not sure how to deal with this one. If you take a look at
> cirrus,madera.yaml it seems to be some complex MFD that is a sound
> device with pin controller and regulator.
>
> I'm not sure: is using pinctrl@ node for that hardware is a correct
> choice?

No, I think you have to drop specifying the node name.

Rob