From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Colin Foster <colin.foster@in-advantage.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 net-next 5/5] net: mscc: ocelot: expose ocelot wm
 functions
Thread-Topic: [PATCH v4 net-next 5/5] net: mscc: ocelot: expose ocelot wm
 functions
Thread-Index: AQHX6TzcVrh3MXhiPEioPLXtrf7S+6wmTGwAgACh6QCAAAZIgIAANqEAgAAA7YA=
Date:   Tue, 7 Dec 2021 15:30:12 +0000
Message-ID: <20211207153011.xs5k3ir4jzftbxct@skbuf>
References: <20211204182858.1052710-1-colin.foster@in-advantage.com>
 <20211204182858.1052710-6-colin.foster@in-advantage.com>
 <20211206180922.1efe4e51@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <Ya9KJAYEypSs6+dO@shell.armlinux.org.uk>
 <20211207121121.baoi23nxiitfshdk@skbuf>
 <20211207072652.36827870@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211207072652.36827870@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JhiUvyrgTblxGRnF6TjCcXktkHI6BS94J4fdSb6nYTw6vVUTrwhDXytDOlvh?=
 =?us-ascii?Q?1aJJ33CJLPrhW9DrCbr5HyPcAwlNWdZejvg66DqTWNq9poGiVjQe5mJ4wmH8?=
 =?us-ascii?Q?nfvdHksyGJRQJKGt1jQMhJc30ImS225jUJ/8/jWWsBf5QI+p3Io+NUwzdqrx?=
 =?us-ascii?Q?Rg+E3L3Iu0n/Fv97sHIpXOKPub0hJkvZhNoyEJ9jYJ5lZz5yyb4Xvekzx5CQ?=
 =?us-ascii?Q?dBdOormP4SrgdCpOuvZ2e+2wCAZnMqoeucZPX16PlFKmRtRKGC9Io1VJYi+5?=
 =?us-ascii?Q?rjBMAumvRPxQIjMlWexutxEqjdAK6U17FI4RPeWyHqwqSnLuVBdNm5L3jApV?=
 =?us-ascii?Q?USkCYKcsn/sdQhdvYOsg5ogitDXKErNX6kqOUkTdBmy1kCoTVQqcOE8/mMOn?=
 =?us-ascii?Q?vTwica3/NIjx2uOYB3liE/fR78GCETYCnL0t9Cyfda49680nrnVTzAtu+87Y?=
 =?us-ascii?Q?KDHT581zqQk8J9cG9P5Ps2QOBOhe9BOyRAJSOssV7FUYQlXuFrOBX80fvN+4?=
 =?us-ascii?Q?tAF+DWqJdhpVAEq1n80CKO/TotgBRkqOZsz9tbllSXy/IgGqmGzCRqvBn2yl?=
 =?us-ascii?Q?iP+igFYf0I4EWEVKZJIKl7YsfgGl0CQAD8ebM26rI2cMOy0/pA1NSrJEEMeE?=
 =?us-ascii?Q?zZwFzRdOfyeOF7hr+1f0V6/tNbXqBUfi40aO5wqi9nNeBBSDRnl2eERMb6Ij?=
 =?us-ascii?Q?Gz7d80wC9VyDk+obNrj4NxKF6dTeGY2a2Jhdie2DHq4kRgpYCGWWY3yb6Sxj?=
 =?us-ascii?Q?zzPt74/xOft/NB6RIeiVN6mPtFPj3zRGrLHEdY2f7DgDd8vQb1Cn68EhT2jA?=
 =?us-ascii?Q?AMW3C6bSZjoK+npGUzknYKA2IRLMbWSI5XmFWkek5auoxVqrYrVqQaesousg?=
 =?us-ascii?Q?XVFX3LBdQ8v1bcMONV2b0HNSAZVLeBToHt2sQ684Md8EkhwLH1bFXBvAT3ZP?=
 =?us-ascii?Q?JvsM0ZHmjHBdQpCPEUkOksMgTRXX4Bghggsa7byt6NF0F3pg6zMFU+O0AntN?=
 =?us-ascii?Q?ogxEchcyoD7rZjBGp89Wey8uQwC9zMI+tac63YbTZX/NoX3+VSVhRGPt8sfH?=
 =?us-ascii?Q?ZVv7TRCWv6YXLpYVsFEW14N9wt3SeU9/Usid3dGVq6MUP+iItK7Bvy+Nw8SJ?=
 =?us-ascii?Q?bK+0dn84PQNj+ASpeb59lHO9zyL+A3VQxnL8rY5im4q9mIlSND2H4X8jeoJY?=
 =?us-ascii?Q?/OY5tlyqD1Tc4DNc4V2VMtarShxfEf7RCXEba90p6XJ7yZhAEZy4tvzpY5ua?=
 =?us-ascii?Q?/4ZJ1YUamKy/5d+N9SKnIY/FmjWEEzpMjbk7QujPARBNMUcsJ1vo0mG/KMPk?=
 =?us-ascii?Q?T8Bf1IFs9f8JcOqXa/ZS8Ds+nAnLza/x4dr8n38Aadc6CO4tRNZXIGnSipyK?=
 =?us-ascii?Q?9uA5Fcoo1REIlG3EC5ZpyPNKnKXugui2o2te8PGqW7QPIWyuFJmVoLXVF2mp?=
 =?us-ascii?Q?U8VsHRSwAiYbTE9abhAU5etSUYSf20VRucLlr/cCf2xgsODTUMcqkFErxSpZ?=
 =?us-ascii?Q?AheRTu+B9ecbWA58CGOQxu+Yqe4QurtO85XsvwMssLvL1B4iLd6J0WSRrdim?=
 =?us-ascii?Q?ZxP+cE64mH/+aV23OrOvYAyz8Mdlx+eYSQ0JHXsAj8IUCtpE1+Tyapoh3nqc?=
 =?us-ascii?Q?fx870zhDKRp66O8QgvDRJAE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4DAFE18A51540241A32A572988E7C9AD@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12933778-2415-4b1e-3824-08d9b99675fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2021 15:30:12.4329
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DV0ps1MZ+/qsb97KuU1RtHBj78Fo//qHY/4tqRVONuEOlIjlUsHxivLjhkmwMUgDiasd/qbdV96Cb2TCffjAlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6013
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 07, 2021 at 07:26:52AM -0800, Jakub Kicinski wrote:
> On Tue, 7 Dec 2021 12:11:22 +0000 Vladimir Oltean wrote:
> > On Tue, Dec 07, 2021 at 11:48:52AM +0000, Russell King (Oracle) wrote:
> > > Thank you for highlighting this.
> > >
> > > Vladimir told me recently over the phylink get_interfaces vs get_caps
> > > change for DSA, and I quote:
> > >
> > >   David who applied your patch can correct me, but my understanding f=
rom
> > >   the little time I've spent on netdev is that dead code isn't a cand=
idate
> > >   for getting accepted into the tree, even more so in the last few da=
ys
> > >   before the merge window, from where it got into v5.16-rc1.
> > >   ...
> > >   So yes, I take issue with that as a matter of principle, I very muc=
h
> > >   expect that a kernel developer of your experience does not set a
> > >   precedent and a pretext for people who submit various shady stuff t=
o the
> > >   kernel just to make their downstream life easier.
> > >
> > > This sounds very much like double-standards, especially as Vladimir
> > > reviewed this.
> > >
> > > I'm not going to be spiteful NAK these patches, because we all need t=
o
> > > get along with each other. I realise that it is sometimes useful to g=
et
> > > code merged that facilitates or aids further development - provided
> > > that development is submitted in a timely manner.
> >
> > I'm not taking this as a spiteful comment either, it is a very fair poi=
nt.
> > Colin had previously submitted this as part of a 23-patch series and it
> > was me who suggested that this change could go in as part of preparatio=
n
> > work right away:
> > https://patchwork.kernel.org/project/netdevbpf/cover/20211116062328.194=
9151-1-colin.foster@in-advantage.com/#24596529
> > I didn't realize that in doing so with this particular change, we would
> > end up having some symbols exported by the ocelot switch lib that aren'=
t
> > yet in use by other drivers. So yes, this would have to go in at the
> > same time as the driver submission itself.
>
> I don't know the dependencies here (there are also pinctrl patches
> in the linked series) so I'll defer to you, if there is a reason to
> merge the unused symbols it needs to be spelled out, otherwise let's
> drop the last patch for now.

I don't think there's any problem with dropping the last patch for now,
as that's the safer thing to do (Colin?), but just let us know whether
you prefer Colin to resend a 4-patch series, or you can pick this series
up without the last one.=