MIME-Version: 1.0
References: <20211206162907.1.I1f5d1eba741e4663050ec1b8e39a753f6e42e38b@changeid>
 <CA+cxXhkmsUMCCJrvbz76nx-ctzSZhg0BFb50qD3nzUon3-Gp+w@mail.gmail.com>
 <CAD=FV=Wr1oai4-oBSJDiuMEV=KYZjW815jL1kh+yuiGdkK3ZbQ@mail.gmail.com> <CA+cxXhmFp31g+_hqj12FVy8Qu7xgssw3aA23OyEBrmTEys9B_w@mail.gmail.com>
In-Reply-To: <CA+cxXhmFp31g+_hqj12FVy8Qu7xgssw3aA23OyEBrmTEys9B_w@mail.gmail.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 7 Dec 2021 09:13:52 -0800
Message-ID: <CAD=FV=Wu6ouGBrjVRqLY42RxrAxMPWZuyY7PZuSAE3VoVM92Rg@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: parade-ps8640: Add backpointer to drm_device
 in drm_dp_aux
To:     Philip Chen <philipchen@chromium.org>
Cc:     dri-devel@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Stephen Boyd <swboyd@chromium.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Dec 7, 2021 at 8:52 AM Philip Chen <philipchen@chromium.org> wrote:
>
> Hi
>
> On Tue, Dec 7, 2021 at 8:13 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Mon, Dec 6, 2021 at 5:44 PM Philip Chen <philipchen@chromium.org> wrote:
> > >
> > > Hi
> > >
> > > On Mon, Dec 6, 2021 at 4:29 PM Douglas Anderson <dianders@chromium.org> wrote:
> > > >
> > > > When we added the support for the AUX channel in commit 13afcdd7277e
> > > > ("drm/bridge: parade-ps8640: Add support for AUX channel") we forgot
> > > > to set "drm_dev" to avoid the warning splat at the beginning of
> > > > drm_dp_aux_register(). Since everything was working I guess I never
> > > > noticed the splat when testing against mainline. In any case, it's
> > > > easy to fix. This is basically just like commit 6cba3fe43341 ("drm/dp:
> > > > Add backpointer to drm_device in drm_dp_aux") but just for the
> > > > parade-ps8640.
> > > >
> > > > Fixes: 13afcdd7277e ("drm/bridge: parade-ps8640: Add support for AUX channel")
> > > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > > ---
> > > >
> > > >  drivers/gpu/drm/bridge/parade-ps8640.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> > > > index 26898042ba3d..818704bf5e86 100644
> > > > --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> > > > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> > > > @@ -449,6 +449,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
> > > >         if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
> > > >                 return -EINVAL;
> > > >
> > > > +       ps_bridge->aux.drm_dev = bridge->dev;
> > > >         ret = drm_dp_aux_register(&ps_bridge->aux);
> > > >         if (ret) {
> > > >                 dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
> > > > --
> > > > 2.34.1.400.ga245620fadb-goog
> > > >
> > >
> > > Signed-off-by: Philip Chen <philipchen@chromium.org>
> >
> > That's probably not quite the right tag. I'm going to assume you meant
> > Reviewed-by? Usually Signed-off-by is added if you were one of the
> > authors of the patch or you were a maintainer that "touched" the patch
> > on its way to landing upstream...
> >
> > -Doug
>
> Sorry for the mistake.
> You're right - I meant to:
>
> Reviewed-by: Philip Chen <philipchen@chromium.org>

Thanks! Since this is pretty trivial/straightforward, I've pushed it.
I ended up pushing it to drm-misc-next instead of drm-misc-fixes to
avoid a merge conflict and because this doesn't seem urgent enough to
justify having to deal with the merge conflict. Please yell if I
should make a different choice in instances like this in the future.

f8378c040381 drm/bridge: parade-ps8640: Add backpointer to drm_device
in drm_dp_aux

-Doug