Date:   Tue, 7 Dec 2021 13:51:10 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     mustafa.ismail@intel.com, shiraz.saleem@intel.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: Fix a potential memory allocation issue in
 'irdma_prm_add_pble_mem()'
Message-ID: <20211207175110.GB70682@nvidia.com>
References: <5e670b640508e14b1869c3e8e4fb970d78cbe997.1638692171.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e670b640508e14b1869c3e8e4fb970d78cbe997.1638692171.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2QzTsOMmNCsnmvQLArU2HyOniohbsCLlvau+RSibgRi+orHhAOrwrU8cEEY7?=
 =?us-ascii?Q?eEkWuEtFHT0Mg/NJSu3RuaqNCPKTaqVRfmIcOvKxVRj2vDpfLp11TJSRC8KI?=
 =?us-ascii?Q?tJWZrwU1JTiiHBiCnz11+lIOa93zWrpzZspl4+0g+wS3qWL3K646ZB3KW5pm?=
 =?us-ascii?Q?WtswLweoCTy2f1uoQ/daHAiv6DFz7gDgkjWNR/Ms6kAP2yu3dXzbFV5ba2Rf?=
 =?us-ascii?Q?YFg0E9QXL+sVs/+6kMNDH4Wmlu+8uO9xXdNTtO+Ftap++BPLCw2a+JeeG6ll?=
 =?us-ascii?Q?XnAFJ4KYgR5RvdRnztOoVMFvFw1VqHtWX1HRokH0FuuknT4JO0WM56Fk1oEc?=
 =?us-ascii?Q?XbsVQQz26JCAuqq2/KtLWFkE27ATTYQ5sKJIXw/QAqSB5HbcCiMcDVNthWab?=
 =?us-ascii?Q?ZvZLOMbcnuum0S1exqeCAPRCleidGDs2gMhpKBGMsi2ffTU4w01341h5o1/x?=
 =?us-ascii?Q?LO2SeH7X0xdpLs/aNdffdY02Osy0fIqC/6CzqlfoOgPwc4pQwRQ1PAYJ6g1/?=
 =?us-ascii?Q?3JEl/0xjIZH0eSKFGaJqoASCXJntricUcPIPrxoLY3Qz+Zro15bfaXw5dRqT?=
 =?us-ascii?Q?cxZcoN717HZl198GDuvvdwQhRpWacUwNmFJMe2nDl3XSUL7QToSke0WVGn0O?=
 =?us-ascii?Q?jLEFcKVnDzFEXewnNFb2YeGlpAaBrSmg5dLxckFn9gQe1HT05fm/+CWaMvAF?=
 =?us-ascii?Q?Z7uiQQb+rwa2cofRrfM+RoQ7e7ARGOV+9UKE+KlgYZZwMZmr3Rr5Ycyx8qMj?=
 =?us-ascii?Q?aoV9tTBgdGrvpagt1eMnzhQLUxQtK4U6iYTgkiw2ygtRtrnlWK6ePA2A1h6f?=
 =?us-ascii?Q?pNBKpe72atgjNwfi65SJ/mXii6X0M/TuJYdFmODonv+b7puqrm+O0kBEEdZo?=
 =?us-ascii?Q?qtS/QImsUqvDBMMQ4jeEn5w6d13Rqc/DxqpHD+Yks6K0QG5xVaTobKzYoy6D?=
 =?us-ascii?Q?bvBdI0VpcFtgUixYiEbd/M+rDlwbMoXMko5evloIK4pfdRz3V2UIXORsqoMR?=
 =?us-ascii?Q?EMLAgNAQ3gCR9vM4gVPrkx+kuDg2+IFbwr1j7flL5SLAoiMTwKC6h2FcCGxA?=
 =?us-ascii?Q?vzSuhkjlMHSVh5+yaKnW0CPC+HjWwtONkeQBPpGUbNofbES5OxhNczBbwN5u?=
 =?us-ascii?Q?YWSrbpp3kFxf3XhZ8U2CYHHMSOhfgWtT43Az3cX47pjNU2KmB1L1rWJsmjZ4?=
 =?us-ascii?Q?/yNxZEdbKI21feda5mnF+7LL+xiSsTy8MO6RxBjtALfO+8GBR7bfU50/y4X1?=
 =?us-ascii?Q?iiQKNfqeUOFxNmVuQakgJqyP07uuYgwywpynyMkXqi3ppqEXn5k1+7effTz0?=
 =?us-ascii?Q?5Ewcsmm7R3dOj0aVtOMQN6ZObyVvnyIRL8RQFkwfht/CBO9ZtS9TLl4Jow6J?=
 =?us-ascii?Q?tDWvjbkvPAB4OyZxTqm3phgwQhEY2YSxV+IBKxnYm3y1QH6h4N2YITG0RyPB?=
 =?us-ascii?Q?Rn43Z+jY9i1gjC2Zd0BiA618zPM8bEuBew84w3pikBb+xvhYNV06SEo0wmQB?=
 =?us-ascii?Q?xjfcmstw1OVa0IjEOogvfcg1DUS7ba433hqvfpAI0tMSljT6JS/LL0NtBocf?=
 =?us-ascii?Q?RhwkDFsU+Axg+b2FbjA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ffb226d-592e-4b61-322b-08d9b9aa42e9
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 17:51:56.8887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GCMcc8erYHx7U5YGdGAOttU642NPeHaaROIJ545JTSpQowufxxnFz6qY9LpzUIQq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5158
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Dec 05, 2021 at 09:17:24AM +0100, Christophe JAILLET wrote:
> 'pchunk->bitmapbuf' is a bitmap. Its size (in number of bits) is stored in
> 'pchunk->sizeofbitmap'.
> 
> When it is allocated, the size (in bytes) is computed by:
>    size_in_bits >> 3
> 
> There are 2 issues (numbers bellow assume that longs are 64 bits):
>    - there is no guarantee here that 'pchunk->bitmapmem.size' is modulo
>      BITS_PER_LONG but bitmaps are stored as longs
>      (sizeofbitmap=8 bits will only allocate 1 byte, instead of 8 (1 long))
> 
>    - the number of bytes is computed with a shift, not a round up, so we
>      may allocate less memory than needed
>      (sizeofbitmap=65 bits will only allocate 8 bytes (i.e. 1 long), when 2
>      longs are needed = 16 bytes)
> 
> Fix both issues by using 'bitmap_zalloc()' and remove the useless
> 'bitmapmem' from 'struct irdma_chunk'.
> 
> While at it, remove some useless NULL test before calling
> kfree/bitmap_free.
> 
> Fixes: 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/infiniband/hw/irdma/pble.c  | 6 ++----
>  drivers/infiniband/hw/irdma/pble.h  | 1 -
>  drivers/infiniband/hw/irdma/utils.c | 9 ++-------
>  3 files changed, 4 insertions(+), 12 deletions(-)

Applied to for-rc, thanks

Jason