Message-ID: <226972a9-2e1c-be72-c970-3a16cd51d2cd@oracle.com>
Date:   Tue, 7 Dec 2021 14:01:28 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] video: fbdev: cirrusfb: check pixclock to avoid divide
 by zero
Content-Language: en-CA
To:     DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Fbdev development list <linux-fbdev@vger.kernel.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>
References: <1635366613-22507-1-git-send-email-george.kennedy@oracle.com>
 <CAMuHMdXcO1K7da=4Ck2X0Rc_pfaM32dDKf0EfdDXNG0HL18h5Q@mail.gmail.com>
From:   George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CAMuHMdXcO1K7da=4Ck2X0Rc_pfaM32dDKf0EfdDXNG0HL18h5Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEdQbDlFeXVnS2NEZFpxemN6ZVlFclJkaEtvZjRTajR0cXBpaWd4RU1PNmQz?=
 =?utf-8?B?ZG9qVHJWcjRHWGJ5YzRiV2hmUEhmNDVRQW5FQ2RNYmpSa1A5a0xlYk82akVp?=
 =?utf-8?B?Nms3OFNSYUZ5cGZIM0Y0dzZwOFBTWnVaZUYrNVJEZWJ0VmNmT2pkTm1Balg5?=
 =?utf-8?B?eDM0Y0dFc1h0ajZQWlFJL1BwZXdKcUxmU3FSOHRjQkRKbE01aFBkWEVROHdF?=
 =?utf-8?B?RTJVMElhbHBHNFZLREExckVHbjFEN1BaNC81T2JOL1JxMkxVZi9WQkh6YTFK?=
 =?utf-8?B?VFBLdkN2M2hqczdxd2Erdms3SkU5YWxnNjJwcmpEYUUxVllXdzhkSjFOR25z?=
 =?utf-8?B?VGo2aEVmY0hxdVhJck5HRndJMDEzR2NubVMyTlpDbDJaUHpVN1VpVmdMM0Z1?=
 =?utf-8?B?RndINDJaRjBacGRkSnBEWEVyN255K01NYkFDZWJmZ0JOTkdNZDhBdnZwckJU?=
 =?utf-8?B?a04wLzJVSUhRVW9NTytManZEYWRRd1BKYnp6VG5aSDlhY3hSd0ZCN2s3RXJn?=
 =?utf-8?B?eDRFeDNhMFA3akZ1eGFJckxpZ3JCK0ptejNRRmlieFRISGwyVjdtQjdubXFi?=
 =?utf-8?B?TkRDblBnM29EMUlyVFpXU0xFcVBMb3V5UXgxdnVOUUlZYm1vTkVBMzA4aG1m?=
 =?utf-8?B?YVdnWVY1bnNPZG1Vd0xlNmJrR1RoQ05NQ0pxUC9rY3Q2RTBhZWxUelpTTzh0?=
 =?utf-8?B?WUtFQnpxNzBoOE1vbVNZdHR0SnJKbmd6WEsxMWc2OFVEczIvS1pPUnk3Zmpk?=
 =?utf-8?B?cmozNVVySjRrblRTTFArelBON05JVStvdHQxU3F2blhxSW9RZ1QrUDBVS0Ji?=
 =?utf-8?B?RGo0YmZSNE9RYmd2N2lnS1JocktiR0FDME5RL25hVHk3NEE4Sy83UitQWjRX?=
 =?utf-8?B?cnVGdy9mY3pwUzUzbDl0SGxSaGlhZDhJZWZ2a25vdzZOQVloZ1orWHphSmZv?=
 =?utf-8?B?ZTI5R2xKZ1R5dysxcytlcDBadzVoUzdMM2ZtMGxoWTRIL2UxVEc4OUd1VkFx?=
 =?utf-8?B?cmk1MGtLOStwM0grdnc0eHJBUXJSVSs0QUpVR3dwWXJoY2RoSWhHR29SVXpB?=
 =?utf-8?B?RTJyOUJJU3lCMXpXUlRKZmpRK3ZVa3J4M0FtZzdETXArOGpQQmM5alhjbVU1?=
 =?utf-8?B?TGE2Yk9SQ2NzL2taYXFxSURydDlrR0VIUVZxWVdnQ3dUVlJaS1BWWG12NDNR?=
 =?utf-8?B?NEFqSGVobXV3VU5rZnhFZW5pcGl3VFlCY0JXVjhXN2M5MFl1emRyazZRTnpR?=
 =?utf-8?B?L0hjS0o4RWF6OXo5UklkcmFlaHg5ZlR6OVJyS1QzV0xrNnhGZys4emNJcWZW?=
 =?utf-8?B?cEcyckdXUVZYdDRaSWlYSlYxTE1xYUF0QU81czhMa2NpV21Mb0ozY3Z2TTJK?=
 =?utf-8?B?UmZqYkI2SGltTWEyeExibGFsbjhSTThNWk9rVERFeWU1V0E0M1kyVlp4eTcw?=
 =?utf-8?B?bnFET3BTV1lGcmFoWVk3S0E4RkhNc0ZHQzl5VWdVSTF6cTMrT1E4SXdkNnVn?=
 =?utf-8?B?T0pjdktYMHdpWUY3NTJoQmFCUGZSNWQ2dmNqNmVxM0twOTQwK3pYeUFrNXNt?=
 =?utf-8?B?bTUrZiszQm1xcnlLQkdSdENrSjFLZjkvSEZ6NklCYjA3ZEVjTy95ektSaXIr?=
 =?utf-8?B?bDVWRkRodzdneVp4Szhyc2laMTVJRHovR0s2bVI2ckxjZHUxL0F3VTNPNitp?=
 =?utf-8?B?QlZwSDFqc2hlUkVzWlpYN01yTzJ4SkkrQ2VXWXlQVThjLzVLV2VVRFk0em9U?=
 =?utf-8?B?TkxEbWlwcFp3ck1QdlZTK0RPZ2JSc0JPdUlqbXhmTGhWdksxWHd4SE8rd2hW?=
 =?utf-8?B?b25jcHFMcEVDdjQySnVYVXIrZzM4NmtEdnpXakxJNEZEVmlhWGN2cDhmeDhS?=
 =?utf-8?B?ZXhBN2xzUTRvMFJldmtGSlBBMU1RemZsNklYOVNETEtYQUFLUmFNTE5DZ0pT?=
 =?utf-8?B?bmRTQzFXNlJrT0hnS3BkRUNQNWtkMzk2QWhGY0lMTmF5TGNhQzE5aG9aWEhm?=
 =?utf-8?B?Q2Q3dS9hVjJzL2FabFV4Qm1xY3NsMGpodUx3NjBEdXMyTUVRRjRudWZpa3U0?=
 =?utf-8?B?Nk9OM1JtOHB4a1l1aGhTbDBBZzRwa080Uy9Jejc4aHM1cWZJRk1BajQ5dEww?=
 =?utf-8?B?REtKOEk0MjdSK1A5MXc1OHZBdDJxZ01JSDh5Znh4UUdjeXYyVVZWQ0Z2UDYx?=
 =?utf-8?B?Y0F5NlpyTGtVMXpKUjMzWlNFbHpQTUd0aUwybHVqcGRFMXYyKzZNOFpQN2hj?=
 =?utf-8?B?UlRwckdMVURrdnB1aS9EWnZQNHN3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f702f520-1f84-4112-4c10-08d9b9b3fbb9
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5192.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 19:01:32.8144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L1RnkzQhB2M20lppnPbZ168mq22mMtxSNOTFuuEImsT2GvMVFH1RhpmctJNUrK1nUrniQvSLsAcGbnwRSxwGIZ9TU0550nlvstWRny8e4Os=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5320
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10190 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112070118
X-Proofpoint-GUID: blDjbxzLCMMTmbVKIvxWpOK5ObVtyy5K
X-Proofpoint-ORIG-GUID: blDjbxzLCMMTmbVKIvxWpOK5ObVtyy5K
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Can the DRM maintainers accept this Reviewed by patch?

Links to the Reviewed by patch:

https://lkml.org/lkml/2021/10/27/982
https://lore.kernel.org/all/1635366613-22507-1-git-send-email-george.kennedy@oracle.com/ 


Thank you,
George


On 10/28/2021 4:05 AM, Geert Uytterhoeven wrote:
> On Wed, Oct 27, 2021 at 10:32 PM George Kennedy
> <george.kennedy@oracle.com> wrote:
>> Do a sanity check on pixclock value to avoid divide by zero.
>>
>> If the pixclock value is zero, the cirrusfb driver will round up
>> pixclock to get the derived frequency as close to maxclock as
>> possible.
>>
>> Syzkaller reported a divide error in cirrusfb_check_pixclock.
>>
>> divide error: 0000 [#1] SMP KASAN PTI
>> CPU: 0 PID: 14938 Comm: cirrusfb_test Not tainted 5.15.0-rc6 #1
>> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2
>> RIP: 0010:cirrusfb_check_var+0x6f1/0x1260
>>
>> Call Trace:
>>   fb_set_var+0x398/0xf90
>>   do_fb_ioctl+0x4b8/0x6f0
>>   fb_ioctl+0xeb/0x130
>>   __x64_sys_ioctl+0x19d/0x220
>>   do_syscall_64+0x3a/0x80
>>   entry_SYSCALL_64_after_hwframe+0x44/0xae
>>
>> Signed-off-by: George Kennedy <george.kennedy@oracle.com>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds