From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Mark Brown <broonie@kernel.org>,
        Ameer Hamza <amhamza.mgc@gmail.com>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Topic: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Index: AQHX6hiZRK5cTb56bk2m5NVbTZyjx6wkenEwgAC48ICAAOYnsIAAl28AgABNGACAALi/0A==
Date:   Tue, 7 Dec 2021 23:53:31 +0000
Message-ID: <TYCPR01MB558131047A6ABA9AA535AAC8D46E9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
References: <20211205204200.7852-1-amhamza.mgc@gmail.com>
 <TYCPR01MB55813B26BB2B3BB6D1E072F2D46C9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
 <20211206092937.GA5609@hamza-OptiPlex-7040>
 <TYCPR01MB5581998AD64AE249C7D86C26D46D9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
 <20211207081522.GA9690@hamza-OptiPlex-7040> <Ya9YxoUqkATCOASh@sirena.org.uk>
In-Reply-To: <Ya9YxoUqkATCOASh@sirena.org.uk>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lf3RngFNAYc3Cbvfd6WtMX8x+F/0AGQaHtANAg6Hy8WDOhOPob6PjeMHiDWT?=
 =?us-ascii?Q?V3rkSQ4KYKllhsuKWdE/0MauVSQfesn71MbOy55PcPZmzahsqJ1ba7F+gnhH?=
 =?us-ascii?Q?NCvstbj82revYUUdYlOp+7SPpdPYPsj0Zsf7TVTrHU0+kj64aY8dyz6lfM8H?=
 =?us-ascii?Q?bH1nSYWTW0sJ2K1i/yKyH5aqSArZlH2mr3Jo05lzgW8B8W2Uy2htk37g3eZT?=
 =?us-ascii?Q?evwmHk2xJizMSX1RUu5ZM/mrLl1n37dE83inaS4E1l7PZ8mP4Re34x9dtHK/?=
 =?us-ascii?Q?0eV9NGZwVg2MvpHiv/DFK7WLKsAeKCcXBtSS5sW7FQkd7tM9hI6uaIcgYedi?=
 =?us-ascii?Q?uvLSIZaTqBUBB1cPnTa7SDRouEyiIKKpbpHnkhVerKMzY4fsiEfXwuEn7FsY?=
 =?us-ascii?Q?HVtSRaRUatYRY3QNoqjDBCQSWSilouCWQlUDZtZOme1hs2bD0RSUtBmZhN2o?=
 =?us-ascii?Q?hN79zyhqem0gIkjYVph117C5GVLK4+VkFHMlICkapzoqjJEXvQM2PRgfrb2C?=
 =?us-ascii?Q?u7/3QHdBmID2b52Jnzlsgkqma1Gk9oe4Ivq/h7rzv4fFRdSAMd0ib1duE/ap?=
 =?us-ascii?Q?W7gqrf8C2I/dpRTwo74hmav0o5rsiqn48lwA9Atk0RaPmgVecj4XXdqFyYRg?=
 =?us-ascii?Q?/kmyB9MhJ/hY/lpChR/vfOqx5oH2/T7hnN0iikQgxDfABqjdsI/y0nKWm1g7?=
 =?us-ascii?Q?GlZeAntsY4zXBP3bD1wCqwPi+g+WMhpd6VnMd03nbczQfDs7nGa2Gtma2dXy?=
 =?us-ascii?Q?iQ71E8ohn0NgODHYc/CHgxUwXomc74jNRXKpl1jnhR3FGXyTyEdQ8wceopb2?=
 =?us-ascii?Q?Po41qRYViip93oD58jdSyKqsTjuVjMTSMg2fP1hDuqkt9cZLclybRYMjtr12?=
 =?us-ascii?Q?WdLojBfRLW9/LGeN+aYIvbMrr90OTr5MrnzApcUGOgu47oZgrbcOR0zqqxFN?=
 =?us-ascii?Q?Qko4koylapeZCo3b1MH530YZrD2DN7FKwCYklR6IupaTL8cFrETRNSLuLjkA?=
 =?us-ascii?Q?Lh2TLv2icftqTyZLgcyo1MgTCFofkh7q9LHAl7tcxkkFR1MYUKmhIcat5On8?=
 =?us-ascii?Q?xcepYwbCV2tm9uv4QhlESPf2sqqB/j0nExRHsQaw+u/Iijy0dF1rVEA/RMuU?=
 =?us-ascii?Q?0BW6Y+7nm7q14aiOEJvVcev4TuEm0ch+l0NfE6RFjTsf64FGYUzK6J6E/IiJ?=
 =?us-ascii?Q?4dlsrSoeI9VSzeFqgQUVeokfBCNwlPdv3OXNvCwFKEsEjWUAoWWIM0tWmEDj?=
 =?us-ascii?Q?/WA7tCAhd79JDQKOXUFs5Dxjt/yTJujAmyK1St2oucP07J7jdSFTDcI6sSoU?=
 =?us-ascii?Q?KkpPCHkjZlRl/9rOXwE/vMSedUOj1dZgT2M8r4upSu9wbOOSAcdEmyE0zby0?=
 =?us-ascii?Q?YzFVN6vrEe1SEZ1Qdx8nmzPGogzIJ8HEzTeG/hmSNEnEmjZ1Cjx1MIbwSB6X?=
 =?us-ascii?Q?LUeqXCFLFMpdLf5rCIFiZln1sEF9qAdNgP55Z1a12Tp9jTe4dnaI1ukrDlZ6?=
 =?us-ascii?Q?OX2zWu2yXdBJuV+h/eb3XJe+diK67bpR2cyLDTlYWSsTEIkBnO+fWUV1dOio?=
 =?us-ascii?Q?7HQipwkqFeqb4v9If9Swi0yy6zuKk1zl1zGank7ek/MJmgHNZRpb5YJlsw4C?=
 =?us-ascii?Q?QTsVjYAdLwxsIL0DPkkjF6JCHgrKS5/InI0aWVxMfv3jLCguBWu69ILVkuNS?=
 =?us-ascii?Q?wbUgudVHDXvHO7SWqgu4yycQQpinm9xLq1YtRaYmKEcSGSmST8f7xK5/Nn9I?=
 =?us-ascii?Q?fCJ8VYfY0Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB5581.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5db3b89-5282-4279-14af-08d9b9dcc637
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2021 23:53:31.7816
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B1yOXLa+yJTe1GP1IpTKnnsl2qUPLURJz7wAJHZKhCXvNobCoj6Yeb9bd1rOq47+a1Vb4CO6D0NG+hgZ2S4YdMMkBKjLVSWlcSACl2GWgHdisPM9IHqwtBiH2znWbhar
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5581
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Ameer, Mark

>> > -	const struct test_adata *adata =3D of_id->data;
>> > +	const struct test_adata *adata =3D of_device_get_match_data(&pdev->d=
ev);
>
>> Thanks, that's a cleaner way. Can you advise how should proceed with
>> this since previous patch is already applied. Should I send a updated
>> version of patch, e.g., v2 or a new patch.=20
>
> Please send an incremental patch on top of what is already applied as
> covered in the message saying the patch was applied.

No worry.
I will post that patch

Best regards
---
Kuninori Morimoto