Message-ID: <5bcb714f-371f-2f8d-cdf6-1736e3ae0aea@intel.com>
Date:   Wed, 8 Dec 2021 08:59:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [x86/signal] 3aac3ebea0: will-it-scale.per_thread_ops -11.9%
 regression
Content-Language: en-US
To:     "Bae, Chang Seok" <chang.seok.bae@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>
CC:     "Sang, Oliver" <oliver.sang@intel.com>,
        Borislav Petkov <bp@suse.de>,
        LKML <linux-kernel@vger.kernel.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>, lkp <lkp@intel.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "Tang, Feng" <feng.tang@intel.com>,
        "zhengjun.xing@linux.intel.com" <zhengjun.xing@linux.intel.com>
References: <20211207012128.GA16074@xsang-OptiPlex-9020> <87bl1s357p.ffs@tglx>
 <81783AEA-1313-4353-837D-8217DEF3B9A2@intel.com> <875ys02lv4.ffs@tglx>
 <9F5B9EA8-B876-487E-AD1C-87A791154F17@intel.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <9F5B9EA8-B876-487E-AD1C-87A791154F17@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eExOdDVDYjNtNVVhSjRyN3ZkSlFvVktjNDQ3M21FZUN1MTl6aDM2NDBwOGpU?=
 =?utf-8?B?TGUyaWZ6cmI2aVgwWDd1QUd0MkxCTmpZZHA5c01MTFZvR1F1WUZVZlI4K2I2?=
 =?utf-8?B?K3RHTHFVb2gwQU1tOWRjRXFHNzRwZ1pWYnFaS2ZXbFdwSW8vS1VxNmppT1ZL?=
 =?utf-8?B?RHNUa24rdWlLK3FkZUJwbnJEOHdNSEQyckxmQnhnVVlXYzcrYzhvWHhtNlJE?=
 =?utf-8?B?emZuMUtpd3VZT04zS292RVVPOEE4a2pZRlluVTdNMSs5SlJIajdyVmxWRHZr?=
 =?utf-8?B?NGxENFpSZWF1Vy9iaHhvbU8wdXpKeEE0TjJZZU1zd3NKNmdwMVc3SkI0bTVn?=
 =?utf-8?B?UmVhZFBDNGJlR0pWY2JXejN0MTdZU2UzS0Z0VVdOSlY4eWoyTTk3d01GN0d3?=
 =?utf-8?B?RGNSZDd5cHlyNG0zUmFsMVJ0OTZQcFl2MW9EVlVKWmpSZFdoTXRkbnE5V01M?=
 =?utf-8?B?NVBET1RhQTFFTG5IK1V1dmw5LzZGdUNaTHVqaVhrTnRqdnZKQmRhRWVhWFFU?=
 =?utf-8?B?UGZqYzFydXNKQWh3ZFovNTE0TUZiNWdUQlNkOGNVRmw2NnlNU2Z6OEpQNjJP?=
 =?utf-8?B?WmU1TGRqeE9NZEFNbWh6eTlQSmZmbUZXV2FlL1ZaU2J0bWVibnZYbk1UakhH?=
 =?utf-8?B?SmtOWHFmYU50MHQ5RnJkQ2F1MlA4STNmR2JWMHBJTFRKakZ2Y1F5OUVlTURp?=
 =?utf-8?B?K3hNRmJscFlxRnRMSFdXa016VDBzMFgzVk4rUWhsdExMZW4xQ2d0c25tRnRZ?=
 =?utf-8?B?QkNkZk9ubldJeDZrc0ZtSG1FditVTHJkTEtoeUxWeEVuL3lGS09DZU1TaW1y?=
 =?utf-8?B?NlEwU050WVduVWRBL3ZZdDZnZk13T2pqd01DZXVieWQ1ZnRqLzlhVGNyL090?=
 =?utf-8?B?NnIyekJWRUVBREJjdlVrTkk0ZzZQWnAwVlphN1pCNWVnT1p1UTlYUnFFelZt?=
 =?utf-8?B?MndDeGRhalhkTXZRK1YwbmUwT1lKNEZiSVNZRXFxd2lvNDZkTzBOSDZZUm55?=
 =?utf-8?B?VDByOVRpdVpWNWZaaGxMemROcERVaEI3OHFNa0Y4ck1pQ09FTHM4eGpsZENC?=
 =?utf-8?B?RDJscjFXTTlYSkV2YWJ4dU93VTl0MWdyUi8rSVU4N2ZMSFg5ckVoNWRaSXhj?=
 =?utf-8?B?ajVmaWxMUnVNaW5WK3lxNmpmMlB6cU1hTWNEV1JPelhBODg2cXhreGpETS95?=
 =?utf-8?B?bHNYb3RTWXRsNHRQU01VNjZNSTVDRmJEY1NpaXpYRUs5cWpJQzl2MjV6VEw5?=
 =?utf-8?B?QURJZWZ3UmhOTVZvUng2Ni9ZNnNRdEVpaFZwVkF3TVdHM0lVMmF4b1BQamJP?=
 =?utf-8?B?OWk1ajJWUWJ4eDVUVC9lY283YUtiT0pUTmRqOTFIdkNuMWdpRjRSb1ZSdkV6?=
 =?utf-8?B?SHkra3JSa2xPUkZvRVF6ck5kU2RvcEc4ZzRWVjFhbWV1RnpxK3lBUmxVNzRH?=
 =?utf-8?B?RkdQRUlncnYzb0dCMVI3dXZKRXVra2h2SVZvVHVZWENzb1Z0Z3ZMVURhRm1U?=
 =?utf-8?B?TGRVd3Rrd25aRENqa1Y2SHduaFNFZEZLWEVkQUlpbDF1cDRBZVpjSWp0ZjVK?=
 =?utf-8?B?akk4dlhIdGd0ZUFUdnB5MmZ4T2IvYmJlRzJ6M2J5VzU0WTVRQVRMSzZCUDF6?=
 =?utf-8?B?c3NweUFwOCtidFBLMmdsRDRIL0FySjR4cDBVU3I1NDFBMkhUZDJoMWNXZEU0?=
 =?utf-8?B?YXlFR3dCRUZucDlERzU5N0NVRWJYamxPNXc2blE5dFhZWTEzTXJ6Y3d3Mmdn?=
 =?utf-8?B?Vkp0ZjNsc3JIYUdwNVV5SjRXdnkwY2FHUk1kb1ZkTWJ6QlVlazJIbVJmVWdI?=
 =?utf-8?B?dWQ3WDB1V1NEVDJBdk4rRXhHbmRnRmJZamFBMnpzMEF5dmdJSC9jQ0t4TzF1?=
 =?utf-8?B?MkNPQ1BGL2FLZzY5ZXFvdmdLa25rMi9Xb0pDd2RuYmVXK2lGd3o3WFdEMFNh?=
 =?utf-8?B?SjNGTlpBamRzSmtHUlcxanpmbjd3T3pRanNybVl6bi9OQlMyMmhIUUdPamxQ?=
 =?utf-8?B?QkFIblJvVlM3QVE3VjNQMDY2V1I5NnpQajVlMlZOa281NEE3bDRCSENJMXVC?=
 =?utf-8?B?aWdHaFNwZ24vcSt2M1M0cmQ2a3V2UXVhV0JJOVgvNWFQeWo5ZlNZNXpYMm15?=
 =?utf-8?B?Tjlsb3drSDIzV0x3Ylc0Zkk1TnlUNktYYzR0ZjJLMW9zeDdaUXdlWko3ckQ1?=
 =?utf-8?Q?Jgg4r8b2IPi95wamHOo5kjA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df057bf5-8260-4000-04f7-08d9b9e5f7f9
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 00:59:21.4511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x29iHNJK72VEj/eya/GWct4hlGBIuBIy9pvPDmhvWGEi0gT0Titiay7vtDZHkoE2AgqMgCJKToSttvbVT1KUUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5823
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/2021 6:17 AM, Bae, Chang Seok wrote:
> On Dec 7, 2021, at 12:36, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Tue, Dec 07 2021 at 18:49, Chang Seok Bae wrote:
>>> On Dec 7, 2021, at 05:38, Thomas Gleixner <tglx@linutronix.de> wrote:
>>>>
>>>> Does that use sigaltstack() ?
>>>
>>> FWIW, I was also wondering about this with:
>>>
>>> $ git clone https://github.com/antonblanchard/will-it-scale.git
>>> $ cd will-it-scale/
>>> $ git grep sigaltstack
>>> $
>>>
>>> But, the test seems to use python via runtest.py. And the python code has
>>> sigaltstack():
>>>    https://github.com/python/cpython/blob/main/Modules/faulthandler.c#L454
>>
>> But how does that affect the test written in C? Mysterious!
> 
> Indeed, I can only see the sigaltstack() trace via the python script. 
> 
> $ strace -f python3.7 ./runtest.py signal1 1>out 2>err
> $ grep -r sigaltstack err
> sigaltstack({ss_sp=0xe13f50, ss_flags=0, ss_size=16384}, {ss_sp=NULL,
> ss_flags=SS_DISABLE, ss_size=0}) = 0
> …
> 
> $ strace -f ./signal1_processes 1>out 2>err
> $ grep -r sigaltstack err
> $ strace -f ./signal1_threads 1>out 2>err
> $ grep -r sigaltstack err
> $

Here is what I got:

From the strace output, we could see:
[pid 3171703] rt_sigreturn({mask=[]})   = 0


Code in kernel:
SYSCALL_DEFINE0(rt_sigreturn)
  restore_altstack
    do_sigaltstack
      sigaltstack_lock


And this matches the perf callstack in the report:

      0.00            +6.3        6.33 ±  8%  perf-profile.calltrace.cycles-pp.native_queued_spin_lock_slowpath._raw_spin_lock_irq.do_sigaltstack.restore_altstack.__x64_sys_rt_sigreturn

The rt_sigreturn was set as signal action restorer by libc during sigaction call. Thanks.

Regards
Yin, Fengwei      

> 
> I don’t get how this syscall could contribute 11% degradation in this test.
> 
> BTW, the current code rejects the reported instruction here:
> 
> $ python3.7 ./runtest.py signal1 295 thread 16
> Usage: runtest.py <testcase>
> 
> Thanks,
> Chang
>