Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85ADCC43217 for ; Wed, 8 Dec 2021 01:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239251AbhLHBdk (ORCPT ); Tue, 7 Dec 2021 20:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234157AbhLHBdj (ORCPT ); Tue, 7 Dec 2021 20:33:39 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AD3C061574 for ; Tue, 7 Dec 2021 17:30:07 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id k2so1364467lji.4 for ; Tue, 07 Dec 2021 17:30:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oY1YzqKk4aWlmDE7Q71zlaeF3NQefpgJ3dA3BCsYPu4=; b=TanE49c9j+vNtjsphwwu+auu7KpkPp9t6oDpqsR9KpWE2jkcvQhEk6OEOBCjxsocAo IpFwWN9l/B5J2eGgk8Y/vEQssZ1DEE2Grjx3JXxUG5gFO0yQIcTfFqYYHIa2ppmo+sPs VWZcZQW5df3SiZwqVx2vzkLqDxpHWIMAbJtmHYirApmq3Mzz5Vhuud99RWwRaquR5hMn Rl/NLQg6IDpEvVQd29AbrfdbUwbZiQEjwTsBqxB786bbtei5ynb0q6Bd293w+peeoXJ/ xQPVxcvPmcIujIKv/yI/7zQUozAsGlfWK9iB9HCWkYAqVqbngMaLTia8w1gyyeVuZqxR upfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oY1YzqKk4aWlmDE7Q71zlaeF3NQefpgJ3dA3BCsYPu4=; b=YaQGCmRwFNWV7c25mo7tPAv2pm90XcDNIk9n/8l1I/qqudtZBxes1SPSJZYFtR63rz Wwe7VEuf5WxvrQD0XQUPr36NWW+MWsOf5OSIKTxqUSdZ/mC0MAcFI2D4uh8HDTPfsKIp IRbCYDYIv966JsrNKBXYe/quwj6M3EYpaipWyM0Ns6gHCH5y4fqXzuPhJmnZmZb8Pl31 UeqYlI2ihLc/+O6V7d/qkR3Y1fD+GPR0c1Wfz4YwjNZozcMtkTVjAUi4J+tiuLdwU5/+ M9dE42GI0/1qDByUpuyNmRaGffG2zchOME/VJ3+en1NZhcOctmll58xa5p/P56lBorYh 0N0w== X-Gm-Message-State: AOAM531zHTlX5C7Bq2Smk+csSSRD4+V0GL0Eh4tpdKCS5my+/qu+oW3U 597l0plVl1wiRAPHrDYnXrliC4cP4iRcq/3mMyM97g== X-Google-Smtp-Source: ABdhPJxmd2LH6zwPwgpPDbCVOETpHSXAwZjmhvHQMjUkXqasuAqG1D74p/kFoM4q8OpYs6prJvtVqpiLKndVoC9He3Y= X-Received: by 2002:a05:651c:292:: with SMTP id b18mr47002761ljo.220.1638927005840; Tue, 07 Dec 2021 17:30:05 -0800 (PST) MIME-Version: 1.0 References: <20211206140313.5653-1-ojeda@kernel.org> <20211206140313.5653-15-ojeda@kernel.org> In-Reply-To: <20211206140313.5653-15-ojeda@kernel.org> From: Nick Desaulniers Date: Tue, 7 Dec 2021 17:29:53 -0800 Message-ID: Subject: Re: [PATCH 14/19] docs: add Rust documentation To: Miguel Ojeda Cc: Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Gaynor , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho , Michael Ellerman , Sven Van Asbroeck , Wu XiangCheng , Gary Guo , Boris-Chengbiao Zhou , Yuki Okushi , Wei Liu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 6, 2021 at 6:07 AM Miguel Ojeda wrote: > > Most of the documentation for Rust is written within the source code > itself, as it is idiomatic for Rust projects. This applies to both > the shared infrastructure at `rust/` as well as any other Rust module > (e.g. drivers) written across the kernel. I'm sure Documentation/rust/ will grow over time; there's certainly more that can be added and core kernel devs will have more questions over time. I'm still running into a SNAFU actually building; see https://lore.kernel.org/lkml/CAKwvOdk9VNenJJN5HnPpGgsHT+OsRsgPGSesQgqMP2aLPWy0NQ@mail.gmail.com/. But I read through all that was added here and didn't find anything problematic IMO. I didn't verify the png's are actually the logo... I don't think `make htmldocs` produced any new warnings, though it's not exactly warning free at the moment (pre-existing before this series). > However, these documents contain general information that does not > fit particularly well in the source code, like the Quick Start guide. > > It also contains a few binary assets used for the `rustdoc` target > and a few other small changes elsewhere in the documentation folder. How is rust-logo.png being included in the docs? Is there something with RST that isn't grep'able for rust-logo.png? > -- > 2.34.0 > -- Thanks, ~Nick Desaulniers