Message-ID: <2918f246-7a48-4395-42bb-d50b943480c6@gmail.com>
Date:   Tue, 7 Dec 2021 20:20:07 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: selftests/net/fcnal-test.sh: ipv6_ping test failed
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>,
        "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc:     "Zhou, Jie2X" <jie2x.zhou@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Li, Philip" <philip.li@intel.com>, lkp <lkp@intel.com>,
        "Ma, XinjianX" <xinjianx.ma@intel.com>,
        "Li, ZhijianX" <zhijianx.li@intel.com>
References: <PH0PR11MB4792DFC72C7F7489F22B26E5C56E9@PH0PR11MB4792.namprd11.prod.outlook.com>
 <20211207075808.456e5b4f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   David Ahern <dsahern@gmail.com>
In-Reply-To: <20211207075808.456e5b4f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/7/21 8:58 AM, Jakub Kicinski wrote:
> Adding David and Zhijian.
> 
> On Tue, 7 Dec 2021 07:07:40 +0000 Zhou, Jie2X wrote:
>> hi,
>>
>>   I test ipv6_ping by "./fcnal-test.sh -v -t ipv6_ping".
>>   There are two tests failed.
>>
>>    TEST: ping out, VRF bind - ns-B IPv6 LLA                                      [FAIL]
>>    TEST: ping out, VRF bind - multicast IP                                       [FAIL]
>>
>>    While in fcnal-test.sh the expected command result is 2, the result is 1, so the test failed.
>>    ipv6_ping_vrf()
>>    {
>>     ......
>>         for a in ${NSB_LINKIP6}%${VRF} ${MCAST}%${VRF}
>>         do
>>                 log_start
>>                 show_hint "Fails since VRF device does not support linklocal or multicast"
>>                 run_cmd ${ping6} -c1 -w1 ${a}
>>                 log_test_addr ${a} $? 2 "ping out, VRF bind"
>>         done
>>
>>     The ipv6_ping test output is attached.
>>     Did I set something wrong result that these tests failed?
>>
>> best regards,

ping6 is failing as it should. Can you send a patch to change the
expected rc from 2 to 1?