Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: [RFC PATCH 2/9] dt-bindings: arm: amlogic: add X96-AIR bindings
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <Ya/Qask7Fpb6mTxb@robh.at.kernel.org>
Date:   Wed, 8 Dec 2021 08:44:40 +0400
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>,
        Benoit Masson <yahoo@perenite.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C1918DC0-F873-4832-AF1A-91AFEF4F7151@gmail.com>
References: <20211130060523.19161-1-christianshewitt@gmail.com>
 <20211130060523.19161-3-christianshewitt@gmail.com>
 <Ya/Qask7Fpb6mTxb@robh.at.kernel.org>
To:     Rob Herring <robh@kernel.org>
Precedence: bulk


> On 8 Dec 2021, at 1:21 am, Rob Herring <robh@kernel.org> wrote:
>=20
> On Tue, Nov 30, 2021 at 06:05:16AM +0000, Christian Hewitt wrote:
>> Add board bindings for the Amediatech X96-AIR STB which ships with
>> model variants distiguished by Ethernet configuration: models using
>> internal 10/100 PHY have a -100 suffix, while models using external
>> Gigabit PHY have a -1000 suffix.
>=20
> Isn't the phy described in DT? Why do you need to describe this 1=20
> difference at the top level?

Users who purchase Android STBs as a cheap Linux media device (or are
reimiaging an existing device when they give up on Android) generally
have no idea what a PHY is, so reading a device-tree file to pick the
correct one is beyond them. Most people blindly try all dtb files for
a class of device until they find one that works, so top-level naming
is simply to hint the process and reduce guesswork. It=E2=80=99s not =
perfect,
but it does appear to reduce the quantity of =E2=80=9CEthernet doesn=E2=80=
=99t work!=E2=80=9D
posts seen in support forums.

Christian

>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>=20
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml =
b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 36081734f720..e9ab0ffe8be7 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -170,6 +170,8 @@ properties:
>>       - description: Boards with the Amlogic Meson SM1 S905X3/D3/Y3 =
SoC
>>         items:
>>           - enum:
>> +              - amediatech,x96-air-100
>> +              - amediatech,x96-air-1000
>>               - bananapi,bpi-m5
>>               - hardkernel,odroid-c4
>>               - hardkernel,odroid-hc4
>> --=20
>> 2.17.1
>>=20
>>=20