Message-ID: <f0a6ae0e-4a6c-7db5-7924-a957f1a0b70b@vivo.com>
Date:   Wed, 8 Dec 2021 14:56:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH] phy: qcom: fix bug: application of sizeof to pointer
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        kernel <kernel@vivo.com>
References: <20211207131642.5313-1-guozhengkui@vivo.com>
 <AO6AKgBME5Y4PNQLIg0Wlap9.9.1638889943341.Hmail.guozhengkui@vivo.com.@PFlhOTZLT3luc080NzhjVnhAcmlwcGVyPg==>
From:   Guo Zhengkui <guozhengkui@vivo.com>
In-Reply-To: <AO6AKgBME5Y4PNQLIg0Wlap9.9.1638889943341.Hmail.guozhengkui@vivo.com.@PFlhOTZLT3luc080NzhjVnhAcmlwcGVyPg==>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUovdVNrZ21vN1RWSXlnWnQrM1Z1b29kcG5ZdDF3d1JqN0pWajJ2dnYwUzN2?=
 =?utf-8?B?VnF6VFB1TWJ4RUZkZVVUME0vVkN5WWt5b1pIMWxGOFRzc29GTGtSd3JCSS9y?=
 =?utf-8?B?b2k5VGJjYzRzd0RuMkcxc0pIY3R6Qk9Od20yUEhiSUdQOTAwL3NYZHBKbDJv?=
 =?utf-8?B?VDdkTld1TlJtbUVMb0p5aVByS0RxV2p5UHc5TW9mVmM3Lys0cXFwd2NRUFV6?=
 =?utf-8?B?aDkwOXRJRzZjaFRkQjM4QUk1Q09HRnJ5N3lOeEwwNXVuTWFCaWttcC9RNVN2?=
 =?utf-8?B?Nm1oaThTNlhmMC9yaE43a1RRbXljUEl4aUxPVGhpQm5ETlREaFIwTzhaWWhT?=
 =?utf-8?B?N1NKOUhEeHRlR2YwNjRtU08zMk9wbnBvMkZUMFVMVGZBZFg1dzZ4eitaelNm?=
 =?utf-8?B?MFF4NXpxK0U3bFV2dzFjeXhaVi9ubzBhRVhaL1hPa1FzZ0lYbUZRTEdIQitl?=
 =?utf-8?B?ak5qYzI0MWFIbmhVdjgweUdRcSt6VkR1dTBMRzR1a2laR1RDMVVmcTJkVkY0?=
 =?utf-8?B?TnAxWlFFZEV0emVDSWZDQjFhU1E2OWhEL0kweTU0V0hvcUx1anBwVjZjUDdU?=
 =?utf-8?B?THVqdjMwZ3pkQVRiZW5QS3FpaGlhRndoZmM2ZTlhUkUwTWNpRFh4ZE1odGFO?=
 =?utf-8?B?c2JrRjFiZi8vSzZ2aEYvbXZ6S0Vjcnl3aVh3SHZycmNnU3A2M1VUUmJZT2dQ?=
 =?utf-8?B?djdDajZvZER4aEZGaFI1L3NTZnZqU1dENElDcjVHMHFoUWhHWHcxUEJMTHdl?=
 =?utf-8?B?UnU2Tk9LbzdSdFQ5YytwVHFIV0FOaWVNbXE2YS9SNCtxZ3ZjenNvOTM2Ynd4?=
 =?utf-8?B?akFpNXlMYm9mbkVNbFBqT3ZjQ3pqOW9tRURhd3hxV1ZJa1lwS0NuMlFUUG5L?=
 =?utf-8?B?T2FvZnNlREQ4T3dWOGh6dGJrSWZtZFBDMThNaTIvb0lENWkvcmVXRkhCbEk0?=
 =?utf-8?B?cnJ4RTd3NXlZcGhZczBNYzlDbnByblBxNjhHaThoMEl4UXBYSUg5REVNUlpI?=
 =?utf-8?B?dTJkQVFjSlBpc1FFdS9QazlLckE1bE4rM3F6MFNqU3VQRVJzeE85VUpGSDkw?=
 =?utf-8?B?d3ZFRkIwc25TV3gyektFc1o2aG1HZ3lxYktTUmZ4ZXlpbXJtanBLUk9udHY0?=
 =?utf-8?B?bTBxYTdJWlFTaGx4YWJYVTdHYjN4TTdGd1pKcWQ0bmprQVZUTmJNOUwrSERB?=
 =?utf-8?B?TS9pYU1yVzZWUjJ1ZDI1SmlyUFZNamJ1YlNWaGdzNEdVdVQ3d1laM2g2T3hX?=
 =?utf-8?B?UjluQ2x2dlN2azV4SFBjQmRUYmY0dmU5eEpqTmNGSG5UMEsrTzhjZlhTQ2lh?=
 =?utf-8?B?OTJtSWc0d3NmL3JUQ1o5NEVHeTlIK0dVZnRUbXlVdnJ2UHJDWVB0Q0luMFhj?=
 =?utf-8?B?eGlIY0o1OWZBYUdyTnZrbUthMWc4R29tYmpiUkVHNzFuN0JoWmFwLzNxQmp0?=
 =?utf-8?B?NUhEam5GQzEwL0k3bElueStkWFdwL0FWb0haQVd3cGRIL2FyUndTS3Y5RWcw?=
 =?utf-8?B?VVllUnpuNTQveENIWWhhSHpEcUxWY2tFSjl1Z2ZaMGxiUVdkSHEvY1huWXZk?=
 =?utf-8?B?Mi91YkpTMitEVVduazNzdEpIZFZCMHlKK0t2ZE1aRUVWNXlUQ1U5ZnhwOWRR?=
 =?utf-8?B?SkFhY2lDOFNkd3JNN3BWd0pZSnBPejR2Mkl6aDVwdWhObGVnSUtyQnRoMzRI?=
 =?utf-8?B?UkVObzQ4UWV6Q1NuZllTUUgrcXBZL3dhQXZlbGdqVUh3NE9hbUUyU09INUhW?=
 =?utf-8?B?OHgxNEwzOTZScDIzTkFTYlh4b0h0cWlJVXRwbnQ5UE1qQllKSG1qbjVUejVD?=
 =?utf-8?B?SFJIZXBDTGtsNm5YZUQ3Z2Rvd0RLcUFYTU84MmNTaWJUT0tYQlVJbHZHTXpZ?=
 =?utf-8?B?TDUwclFsK3JDSnB1cG1FSnFtN1R6QmNvQUNsMkh0cCtSbE5sYzE1VHB2NWE2?=
 =?utf-8?B?ZkVGb1U5RWQvWHlNOVE1aFNHTnI0ajA1REljWHY3aVRxSXVOWklQUERSSW01?=
 =?utf-8?B?c0ZWM09URVRZdUNzWFppWkp5Umh3ZTVpQ29lU1g3OXJ5ajBpRlQ0QVNmRzVx?=
 =?utf-8?B?RHp3OGs0Y2xScnhPYnRMUWpLMWlUaWtnNUZFM0x6WkFuWmwyQ2NxTGJCU003?=
 =?utf-8?B?dXJ5YXN3ZEV1NWVRWTQwKzlhMGJPL1JxRUpEaFk3UzAyREpNQXZPV21taXZ0?=
 =?utf-8?Q?z2fqZdssf2867gyYvHUaYxY=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cc55f9a-cad5-46e2-0b1a-08d9ba17e12e
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 06:56:37.8134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4youiS7BKx4+ShqfLC9ktpGhIOPWKN3Zlx633DrrYbcCevPTbf5TFyM1kurwBtK1ahrelw0Gvyos69VgFcgA+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB3427
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/12/7 23:13, Bjorn Andersson wrote:
> On Tue 07 Dec 05:16 PST 2021, Guo Zhengkui wrote:
> 
>> Fix following coccicheck error:
>> ./drivers/phy/qualcomm/phy-qcom-edp.c:574:31-37:
>> ERROR: application of sizeof to pointer.
>>
>> Use sizeof(*data) instead.
>>
>> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
>> ---
>>   drivers/phy/qualcomm/phy-qcom-edp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
>> index 17d5653b661d..5fe4eab9cac1 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
>> @@ -571,7 +571,7 @@ static int qcom_edp_clks_register(struct qcom_edp *edp, struct device_node *np)
>>   	struct clk_init_data init = { };
>>   	int ret;
>>   
>> -	data = devm_kzalloc(edp->dev, sizeof(data), GFP_KERNEL);
>> +	data = devm_kzalloc(edp->dev, sizeof(*data), GFP_KERNEL);
> 
> Ouch, thanks for catching that!
> 
> But the clk_hw_onecell_data actually has a variable size array at the
> end and as you can see further down I store 2 items in that array.
> 
> So that sizeof should be struct_size(data, hws, 2)
> 
> Would you be willing to update your patch with that?
> 

OK, I will commit another patch. Do you mind I add a "Suggested-by" tag 
of your name in the new patch?

Zhengkui

> And please add:
> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver")
> 
> Regards,
> Bjorn
> 
>>   	if (!data)
>>   		return -ENOMEM;
>>   
>> -- 
>> 2.20.1
>>