MIME-Version: 1.0
Date:   Wed, 08 Dec 2021 07:45:11 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     =?UTF-8?Q?qinjian=5B=E8=A6=83=E5=81=A5=5D?= <qinjian@cqplus1.com>
Cc:     robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
        tglx@linutronix.de, p.zabel@pengutronix.de, linux@armlinux.org.uk,
        broonie@kernel.org, arnd@arndb.de,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        =?UTF-8?Q?Wells_Lu_=E5=91=82=E8=8A=B3?= =?UTF-8?Q?=E9=A8=B0?= 
        <wells.lu@sunplus.com>
Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller
 driver
In-Reply-To: <39f9b853af7c44cb94421354744512a8@cqplus1.com>
References: <cover.1638515726.git.qinjian@cqplus1.com>
 <e88ea4cf28ba69a41f6d1b4dd4128b82a6095c29.1638515726.git.qinjian@cqplus1.com>
 <87r1ao23fp.wl-maz@kernel.org>
 <39f9b853af7c44cb94421354744512a8@cqplus1.com>
User-Agent: Roundcube Webmail/1.4.12
Message-ID: <ce867937861df454823eb703bfd29256@kernel.org>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2021-12-08 07:15, qinjian[覃健] wrote:
>> > +void sp_intc_set_ext(u32 hwirq, int ext_num)
>> > +{
>> > +	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
>> > +}
>> > +EXPORT_SYMBOL_GPL(sp_intc_set_ext);
>> 
>> No way. We don't export random symbols without a good justification,
>> and you didn't give any.
>> 
> 
> This function called by SP7021 display driver to decide DISPLAY_IRQ
> routing to which parent irq (EXT_INT0 or EXT_INT1).

Based on what? How can a display driver decide which parent is
appropriate? What improvement does this bring?

> In previous patches, which defined in DT, parsed & processed @
> sp_intc_xlate_of()
> From your comment, this is a SW decision. So I removed it from DT &
> intc driver, only
> export this function to access the related intc reg.

If a decision has to be made, it has to be done in the interrupt
controller driver, or rely on the standard API. Exporting random
low level functions to other random drivers is not acceptable.

         M.
-- 
Jazz is not dead. It just smells funny...