Date:   Wed, 8 Dec 2021 08:58:14 +0100
From:   =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Denis Kirjanov <dkirjanov@suse.de>,
        Julian Wiedmann <jwi@linux.ibm.com>
Subject: Re: [PATCH net-next v6 4/4] net: ocelot: add FDMA support
Message-ID: <20211208085814.19e4ec71@fixe.home>
In-Reply-To: <20211207194514.32218911@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20211207154839.1864114-1-clement.leger@bootlin.com>
        <20211207154839.1864114-5-clement.leger@bootlin.com>
        <20211207194514.32218911@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Le Tue, 7 Dec 2021 19:45:14 -0800,
Jakub Kicinski <kuba@kernel.org> a écrit :

> On Tue,  7 Dec 2021 16:48:39 +0100 Clément Léger wrote:
> > + * struct ocelot_fdma - FDMA struct
> > + *
> > + * @ocelot: Pointer to ocelot struct
> > + * @base: base address of FDMA registers
> > + * @irq: FDMA interrupt
> > + * @ndev: Net device used to initialize NAPI
> > + * @dcbs_base: Memory coherent DCBs
> > + * @dcbs_dma_base: DMA base address of memory coherent DCBs
> > + * @tx_ring: Injection ring
> > + * @rx_ring: Extraction ring
> > + */
> > +struct ocelot_fdma {
> > +	int irq;
> > +	struct net_device *ndev;
> > +	struct ocelot_fdma_dcb *dcbs_base;
> > +	dma_addr_t dcbs_dma_base;
> > +	struct ocelot_fdma_tx_ring tx_ring;
> > +	struct ocelot_fdma_rx_ring rx_ring;
> > +	struct napi_struct napi;
> > +	struct ocelot *ocelot;  
> 
> one more nit:
> 
> drivers/net/ethernet/mscc/ocelot_fdma.h:156: warning: Function parameter or member 'napi' not described in 'ocelot_fdma'

And base does not exists anymore. I will also reorder the members in
the doc to match the struct.


-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com