Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F85C433FE for ; Wed, 8 Dec 2021 10:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbhLHKJI (ORCPT ); Wed, 8 Dec 2021 05:09:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbhLHKJF (ORCPT ); Wed, 8 Dec 2021 05:09:05 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF29EC061746; Wed, 8 Dec 2021 02:05:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5E72ACE20CC; Wed, 8 Dec 2021 10:05:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D05B1C00446; Wed, 8 Dec 2021 10:05:18 +0000 (UTC) Date: Wed, 8 Dec 2021 11:05:14 +0100 From: Christian Brauner To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Al Viro , Andrew Morton , Guenter Roeck , Kees Cook , Linus Torvalds , Masahiro Yamada , Matthew Wilcox , Nathan Chancellor , Nick Desaulniers , Stephen Rothwell , kernel test robot , Ingo Molnar , Peter Zijlstra , Will Deacon , Waiman Long , Boqun Feng , Thomas Gleixner , Tejun Heo , kernelci@groups.io, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [RFC 3/3] headers: repurpose linux/fs_types.h Message-ID: <20211208100514.7egjy5hraziu4pme@wittgenstein> References: <20211207150927.3042197-1-arnd@kernel.org> <20211207150927.3042197-4-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211207150927.3042197-4-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 07, 2021 at 04:09:27PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > linux/fs_types.h traditionally describes the types of file systems we > deal with, but the file name could also be interpreted to refer to > data types used for interacting with file systems, similar to > linux/spinlock_types.h or linux/mm_types.h. > > Splitting out the data type definitions from the generic header helps > avoid excessive indirect include hierarchies, so steal this file > name and repurpose it to contain the definitions for file, inode, > address_space, super_block, file_lock, quota and filename, along with > their respective callback operations, moving them out of linux/fs.h. > > The preprocessed linux/fs_types.h is now about 50KB, compared to > over 1MB for the traditional linux/fs.h, and can be included from > most other headers that currently rely on type definitions from > linux/fs.h. > > Signed-off-by: Arnd Bergmann > --- I tried to apply the series to take a closer look but it fails to apply cleanup down to v5.15 and any release after that. What's the base I should use for this?