From:   Yihao Han <hanyihao@vivo.com>
To:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] samples/bpf: fix swap.cocci warning
Date:   Wed,  8 Dec 2021 03:34:07 -0800
Message-Id: <20211208113408.45237-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oUJhKhdLIdkkjkIWvt7CMraKzORPxTPu3DZsKCYDDGuk0y5Q6nnv8ih+W1sY?=
 =?us-ascii?Q?n3uTTxgibvf+f8Cp62Nz9cpkM0IwUxlvi7dQ0GkCYcJlktpA2OkS3lwhrivb?=
 =?us-ascii?Q?oa2BJuYF9NA//Bg0VusGhyZo+hHBjMipuQknku6P58Wm+J9kjVrM/wevRHHO?=
 =?us-ascii?Q?ePArgEXreKIx+xEqEa8EpkwR1NApBS3cW7Pf5FP9PKQ9iO1qzR/1KRgKt8Qh?=
 =?us-ascii?Q?vit7zDx6P1oz111HzoixaUfcKFHBXXnNHF9nll/PQqxNnQpT4eEw10amvPUW?=
 =?us-ascii?Q?BpmCjZ2KuTLrHJSlyqc+dre2BtgKQKVb/2B7zvVwXZO9h70IGazDV0ROG2A7?=
 =?us-ascii?Q?D2poO21WFL5j4CdgvbzUWeCb+xffxPQtjfLZ3y96sDjIILffra/oO/uIVsLq?=
 =?us-ascii?Q?h6kY01OH/Wu/vV/3gWrYJvEVYu7F3/GqLda3GMHsNvRVBTByseKVzJUGFgfU?=
 =?us-ascii?Q?7LYV3UCJ1610V1gk7d2Qi4/G2j1Gh14py3OegI+ro8ciiC+hgZCq3szfwymX?=
 =?us-ascii?Q?fpxMZXXp2OQPfrc9ZsO9/weEXIh7Rlod2wkwh15emN+2/QUbfGHMu8b9NYm8?=
 =?us-ascii?Q?wAKH4MK/RFuJe+k7C+80XFUx4oZFASHUEbxZ/h0oL5DyyK3SEszD8jhmkTDd?=
 =?us-ascii?Q?15sxvhXRQanin8QIzuc13FhHEgSbfPYJLPhA1eLTy94KLal0buaLS4U4r/UT?=
 =?us-ascii?Q?fxdmy5oS7L2pY4JBy6NRfmb+J5Uzt1fHKTfB79cqs/OkfTWg9bIWJMYmQ9VA?=
 =?us-ascii?Q?rTTzdR67yeO/TYsNm/4CQntJofuADhXp4tIHlUUms4br8EKm4CrBGCjZb64s?=
 =?us-ascii?Q?6AqN5HqlJYZoQgoxSUKJJr2+SL3z2ukNqT+meE6fr0Ge18TwAtJjENb20eHl?=
 =?us-ascii?Q?Y6XuMSAU4Hb1kNFx6S+CZO7G89PIHyQreECjwXbmuqNfJ+jZgP2hB08tfM7D?=
 =?us-ascii?Q?n5pA+gJ0uqMtkGsgXh1NFUMvTahrk/jdTtxBgf5qB+cbmM0Cu6FcEoYwW2cT?=
 =?us-ascii?Q?5EoddfJseu68+yUepPuw0fLv/KjRY/11tRr4qb9/fDQUgwpqsbWt1xFA5H3t?=
 =?us-ascii?Q?1qtfwqhojNBCl7i6RxrmBfo4WZgHa6mW5V5Gou27ZHqxRSPLDzuWo6iUeUM9?=
 =?us-ascii?Q?K3cwsX7pHe7KbeEiOH+3XzL1AgP4PBtnWQQvC0xfDn1Q7nAm7QaAXb91hCxa?=
 =?us-ascii?Q?cDCxaO+g3pndXwKHX5QEYJpcznjZ9/yOk3BPGsg61VV+yoHyOnkXv8dDYIWf?=
 =?us-ascii?Q?6+/gdPOEE+XtlxYQB3cH5fqhGee2J1LZF4II4QAEj0PNgOlGZSmu5H9wbatX?=
 =?us-ascii?Q?iXUi+knZmW+sbCf5mwYBMmlhcXS4BmzF0bpeeB9QcTxzSDQP8PTQCiSDx7w/?=
 =?us-ascii?Q?EIjc0rQksepXMJEkYu18etOSXyfSmQ3zSOvGROxsliqww4psV2D0lQXu1h4n?=
 =?us-ascii?Q?nWzmEz6kNyt9IMKLZd9vNSY8+Mu0HG4Stbj4qvMIIHsIzjHY6Vm4Dw/SptTG?=
 =?us-ascii?Q?JzYLlJHrempE+bioOxPmEf1gwXhZBYhbxILrWF7wFBEH8DEsaceF6Up9efEY?=
 =?us-ascii?Q?1Upb4/O543JCbIR/VEW5IQAHN2+WaIvOnFp22+1DhCgh4feKWHuranVhRv0x?=
 =?us-ascii?Q?YTRiWV1yEWHu6IcermV7Wss=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef4aa9e4-0558-46c3-4f91-08d9ba3eaebd
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 11:34:23.3470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 42h26rvQmzyj0lWD9D2u1ZZ1+Cz7hRS1nOn9Uva/yxCT1IVmQEfFvyXfAbZExyGQvJ1ksvF8PQTV7o4Y5mE6Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2655
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following swap.cocci warning:
./samples/bpf/xsk_fwd.c:660:22-23:
WARNING opportunity for swap()

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 samples/bpf/xsk_fwd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c
index 1cd97c84c337..e82582b225d3 100644
--- a/samples/bpf/xsk_fwd.c
+++ b/samples/bpf/xsk_fwd.c
@@ -653,9 +653,7 @@ static void swap_mac_addresses(void *data)
 	struct ether_addr *dst_addr = (struct ether_addr *)&eth->ether_dhost;
 	struct ether_addr tmp;
 
-	tmp = *src_addr;
-	*src_addr = *dst_addr;
-	*dst_addr = tmp;
+	swap(*src_addr, *dst_addr);
 }
 
 static void *
-- 
2.17.1