Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB52C433FE for ; Wed, 8 Dec 2021 12:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233255AbhLHMYo (ORCPT ); Wed, 8 Dec 2021 07:24:44 -0500 Received: from mga04.intel.com ([192.55.52.120]:13096 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231336AbhLHMYn (ORCPT ); Wed, 8 Dec 2021 07:24:43 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="236557657" X-IronPort-AV: E=Sophos;i="5.87,297,1631602800"; d="scan'208";a="236557657" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 04:21:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,297,1631602800"; d="scan'208";a="461672961" Received: from mylly.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by orsmga003.jf.intel.com with ESMTP; 08 Dec 2021 04:21:09 -0800 Message-ID: <584f5db4-4126-9203-56f3-5358eeac44c0@linux.intel.com> Date: Wed, 8 Dec 2021 14:21:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.2 Subject: Re: [PATCH v1 04/11] i2c: designware-pci: Convert to use dev_err_probe() Content-Language: en-US To: Andy Shevchenko , Wolfram Sang , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: Mika Westerberg , Ajay Gupta References: <20211207192159.41383-1-andriy.shevchenko@linux.intel.com> <20211207192159.41383-4-andriy.shevchenko@linux.intel.com> From: Jarkko Nikula In-Reply-To: <20211207192159.41383-4-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/21 21:21, Andy Shevchenko wrote: > + if (id->driver_data >= ARRAY_SIZE(dw_pci_controllers)) > + return dev_err_probe(dev, -EINVAL, "invalid driver data %ld\n", id->driver_data); > I know checkpatch.pl doesn't complain this but for my taste readability would be a bit better if error causing id->driver_data is split into another line. Jarkko