Message-ID: <c709ea1a-8074-76f2-5e1e-cb2dc7af8eba@linux.intel.com>
Date:   Wed, 8 Dec 2021 14:35:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [PATCH v1 03/11] i2c: designware-pci: Use temporary variable for
 struct device
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Ajay Gupta <ajayg@nvidia.com>
References: <20211207192159.41383-1-andriy.shevchenko@linux.intel.com>
 <20211207192159.41383-3-andriy.shevchenko@linux.intel.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20211207192159.41383-3-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/7/21 21:21, Andy Shevchenko wrote:
> Use temporary variable for struct device to make code neater.
> 
> While at it, rename variable of struct dw_i2c_dev pointer to i_dev.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c | 99 +++++++++++-----------
>   1 file changed, 50 insertions(+), 49 deletions(-)
> 
I think struct dw_i2c_dev *dev to *i_dev renaming would be better to do 
consistently through the all drivers/i2c/busses/i2c-designware-* or 
leave as is?

Jarkko