MIME-Version: 1.0
References: <20211207083222.401594-1-chi.minghao@zte.com.cn>
In-Reply-To: <20211207083222.401594-1-chi.minghao@zte.com.cn>
From:   Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date:   Wed, 8 Dec 2021 13:35:35 +0100
Message-ID: <CAM9Jb+hfa7fejFqmg3A07kjrZTf++QKCYx=0oArBNBqNsMrv1A@mail.gmail.com>
Subject: Re: [PATCH] mm:remove unneeded variable
To:     cgel.zte@gmail.com
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        chiminghao <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cm>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> return value form directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cm>
> Signed-off-by: chiminghao <chi.minghao@zte.com.cn>
> ---
>  mm/truncate.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/mm/truncate.c b/mm/truncate.c
> index cc83a3f7c1ad..41b8249b3b4a 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -205,7 +205,6 @@ static void truncate_cleanup_page(struct page *page)
>  static int
>  invalidate_complete_page(struct address_space *mapping, struct page *page)
>  {
> -       int ret;
>
>         if (page->mapping != mapping)
>                 return 0;
> @@ -213,9 +212,7 @@ invalidate_complete_page(struct address_space *mapping, struct page *page)
>         if (page_has_private(page) && !try_to_release_page(page, 0))
>                 return 0;
>
> -       ret = remove_mapping(mapping, page);
> -
> -       return ret;
> +       return remove_mapping(mapping, page);
>  }
>
>  int truncate_inode_page(struct address_space *mapping, struct page *page)

 Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>