From:   Peng Fan <peng.fan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node
Thread-Topic: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node
Thread-Index: AQHX22M3wqoeGEsc2kKun9YdpXFw4qwookUAgAATN0A=
Date:   Wed, 8 Dec 2021 13:22:05 +0000
Message-ID: <DU0PR04MB94179D73EA3E9585D76F2DAB886F9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20211117032740.2518926-1-peng.fan@oss.nxp.com>
 <20211117032740.2518926-3-peng.fan@oss.nxp.com>
 <20211208121000.GG4216@dragon>
In-Reply-To: <20211208121000.GG4216@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3RfJVva76Z+3NDhJ0PlzSBQvzvFALkQm6wPOqzC2FszxQRkrILA2TpA7+yaf?=
 =?us-ascii?Q?FEA61hjCwrjAigciAOJkJm2fh8/s1XI8jpEXUeiBmVuK2/tY/raThcxcZDYK?=
 =?us-ascii?Q?FLpWgh+8QpBAfaEsO9zhPA3WAauQuUnUsh26h1y+wGa9akBbPQsGRkqIXFHQ?=
 =?us-ascii?Q?iD3A5VYjoHhhNR3zLkSmJNJviTdebdqSLOA7/78r/tXe0RC7brC5c1xgAm6o?=
 =?us-ascii?Q?8bxM7ZBg85M0QZfqVrIqTeo+SqP/5033H9SribwQK+ykXVqaa/WqnsO/SRMQ?=
 =?us-ascii?Q?1FTIuaXdmC+UAjpv9hJACLLdDhtXdmGzCQGp30iB7nHhDne0H5NmBRrgDkFZ?=
 =?us-ascii?Q?jwv6+PjcmI+iduBG78ClXa2C8uEql5KIalcLYGxUodBe9hMEn92/pDC96Tej?=
 =?us-ascii?Q?AiO9gvYgV6fj1/+9T5VcA8cUePu8vu6ATWwiCSS1sJ1sy3Hvu4Uz4tUZQUpZ?=
 =?us-ascii?Q?I0CKNbjx3/xUqyygTPKgQib9WMtUvb1cA2ICksgY+vsjA+ow3+Tcj/sMGykg?=
 =?us-ascii?Q?8PNX3LN+YH4QClcVxqi0P49YtmqL6U9o/tZ7CwS4XD+WgOwKWlphxM50ZPq7?=
 =?us-ascii?Q?mwi7kM/qTk4p6H1JfJSeOPsZdFhWE7zxLLv/SYG08NFV1c+dHcOdyE3eN0Nt?=
 =?us-ascii?Q?rHxum1g4l6XbWdS2foOwjVBKwwV6cvWHH/AaakqpBjGdMbipk/4T/58mjseN?=
 =?us-ascii?Q?wrDnUqzvLtJsLhEOyc2Ydz1F3qeBGhUtbz7rRcS2Sm1LXzNpkyQX8TNVXCtp?=
 =?us-ascii?Q?zLubW73X1gwcvLS4ALeoKW8DaUB5lZ4ORAeyvKN6Aws6aQlNdoJS3QP66D2f?=
 =?us-ascii?Q?jc6hTzHA6Zi0d8Gmz2wP9h8FdI6gplL5dI2IH+qeJUyFDenIba65FiDleawx?=
 =?us-ascii?Q?IcQDkhzk5OzAo9pkNQIK1x1PxE+g4W+m60gEJXKf658qSVPRryTPgztLDlS/?=
 =?us-ascii?Q?9JGk5bfvryTJLJ+N9DIC9tcWAyt24IvtrEImizIlCSB5Fmc9tcuXhEx6RNmZ?=
 =?us-ascii?Q?+HevuNAq8YX2LwAlgJ+RONenmSaflSPRwej7lX+o3utDDMHSGtjGlBcyBk14?=
 =?us-ascii?Q?sVrXQOB8gQR0bi1NKzP5mWeho6ggBTrNH6tugSmTuBuT+E2EHyqbMsYZ5qDT?=
 =?us-ascii?Q?y8ltGxWR2QhhgID7fBudxWMlnV7Hn9TO7PV+iAtj+MAV4VeO6xlfkouGCvCG?=
 =?us-ascii?Q?OruGlulR9ceorHJaQAMMNYr09uWfvnNBiccl7H7fvnznYcs+WogGKaMX9RuD?=
 =?us-ascii?Q?xRTts+Hwbp/TuZuTy/NPjfXAOf8NyrLhXDXCGiKSr4MFY7JtDTETzk2GOlX4?=
 =?us-ascii?Q?ZjqTwya+LO9GCwP/BN4Kq6CxvjZFaGexhhN8qqYxDQnqxvsZJ/siGsZR+UW/?=
 =?us-ascii?Q?D2R+6KPIFaxSWDljywoL8tBx6bx8Whacmrra495bn6qg/bOP1f/WYsgSbkX7?=
 =?us-ascii?Q?oByq/PwDxuILa/A3TvNVe8uYmoHc7uTxqgjIUFQBKX02w+4LStEp+SWAzISu?=
 =?us-ascii?Q?kTyMd/39e4WB3XDiDK3rp9cdb7FRcLt9IRrtwPxqvIhXaArvWLD7W2hb5f9g?=
 =?us-ascii?Q?bd/KHigDLAQ8XJFg5qeFmq2dDn3B7ogGFLR4mlUyBdRD8vDuRgLJYHKUn1mv?=
 =?us-ascii?Q?Qg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f25bb869-423a-4b0b-fa5d-08d9ba4dbad0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 13:22:05.7956
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lP5/E/2tTD2xKZbDMFJO4KcjlnJFwjNU8t4KjUjF6uYMLtceBkxNINkO2EPoAUC1LnFjHrOHOl3uXPhNYkxagA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9372
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn,

> Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node
>=20
> On Wed, Nov 17, 2021 at 11:27:39AM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX8ULP use scmi firmware based power domain and sensor support.
> > So add the firmware node and the sram it uses.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 35
> > ++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > index fb8714379026..d567ef93f8d8 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -6,6 +6,7 @@
> >  #include <dt-bindings/clock/imx8ulp-clock.h>
> >  #include <dt-bindings/gpio/gpio.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/imx8ulp-power.h>
> >
> >  #include "imx8ulp-pinfunc.h"
> >
> > @@ -102,6 +103,40 @@ sosc: clock-sosc {
> >  		#clock-cells =3D <0>;
> >  	};
> >
> > +	sram@2201f000 {
> > +		compatible =3D "mmio-sram";
> > +		reg =3D <0x0 0x2201f000 0x0 0x1000>;
> > +
> > +		#address-cells =3D <1>;
> > +		#size-cells =3D <1>;
> > +		ranges =3D <0 0x0 0x2201f000 0x1000>;
> > +
> > +		scmi_buf: scmi_buf@0 {
>=20
> Hyphen is more recommended than underscore for node name. =20

Just send out v2 to address this issue.

Or just
> follow the naming in arm,scmi.yaml example?

No need to follow its name there, it support many protocols
and need different shmem for performance and others.

Thanks,
Peng.


>=20
> Shawn
>=20
> > +			compatible =3D "arm,scmi-shmem";
> > +			reg =3D <0x0 0x400>;
> > +		};
> > +	};
> > +
> > +	firmware {
> > +		scmi {
> > +			compatible =3D "arm,scmi-smc";
> > +			arm,smc-id =3D <0xc20000fe>;
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +			shmem =3D <&scmi_buf>;
> > +
> > +			scmi_devpd: protocol@11 {
> > +				reg =3D <0x11>;
> > +				#power-domain-cells =3D <1>;
> > +			};
> > +
> > +			scmi_sensor: protocol@15 {
> > +				reg =3D <0x15>;
> > +				#thermal-sensor-cells =3D <0>;
> > +			};
> > +		};
> > +	};
> > +
> >  	soc@0 {
> >  		compatible =3D "simple-bus";
> >  		#address-cells =3D <1>;
> > --
> > 2.25.1
> >