Date:   Wed, 8 Dec 2021 11:54:42 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Cedric Le Goater <clg@kaod.org>,
        xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Will Deacon <will@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Vinod Koul <vkoul@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties
Message-ID: <20211208155442.GY6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.913603962@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.913603962@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nMIbCOUusUhlSao/i/r5Za3Hl4BbRO+/ixs7S7Sbyo2qpr0bfkFiQlTn5Ukp?=
 =?us-ascii?Q?P9Qt4DdTE5PVo3yyhRiGRwhkA68y/LNtU52Fziau3Gl43RxMGaWptIwDIVDI?=
 =?us-ascii?Q?k2WAigMy/+uhzZX00hUDaobg5b3oHxuJ8hohRAV1v2GiLYYtM0ynZnfQQjAB?=
 =?us-ascii?Q?mlQalBjVF9cK2gjSezEAuDeHRMUbYeJ/OAaOGZgbW++PIeAbhw2UI2e0+ZX8?=
 =?us-ascii?Q?xVoUHeZoTP2UCEqqOUZbUEr6SjFkrEELyw8rS772rL5FXDa2XDp1qulBWJWG?=
 =?us-ascii?Q?R+PNZT8sIAdB6sFbvcpQjBq3OIwiZdCFvLe1ElcjRV54q5hOV2cBtmQE+lUn?=
 =?us-ascii?Q?fsXDKKt/C41q8Lv9cn1hw/3jW+fQI7fqzdozXgN1elLr5QiaoItKrB7YJItE?=
 =?us-ascii?Q?n3klZpFCv+p5y7Zker72MVCfRQXWzFXMSWZGJZWpKG7ahQF/OOIa9kc1UlXH?=
 =?us-ascii?Q?C+0irnLb+NSJiTLh8/xTRgufYznCzi4qW8GFn9ACMF+nNqqoRFQdwsJhsrR0?=
 =?us-ascii?Q?/EP6Gq9ufz86gsxSELLy8FLuUt/eo3Dpu6PZTeArAvgu4oPLxgYPgplFYnKG?=
 =?us-ascii?Q?nh9UJuW9aZnQEhPgcWruA5/EpYRuD+7FCTEXEgsmDJmGazfBa39WP+T56tfW?=
 =?us-ascii?Q?zRDWAxxBaWavK0tl/o6lPM27fgXDmntYqlNvEzCssNEyCOxpY3WKpPrnsJ5T?=
 =?us-ascii?Q?pXOJTJoHiP1jwIolm2bNVxgChb6CCxiJb7ZhRtRDUDRxYxdzAEDRV+IKb2qB?=
 =?us-ascii?Q?E/sMcNssiGLgWKB7tWVCc3IUI06cg08cOLUF8m842WhBNP1Z9pMCMD62WUq2?=
 =?us-ascii?Q?GlpIqSnJXfRnEnW+j7flQyCbCtvniyCu3M9X1Hns9xZK5ZUepyoHe3G7Kqfp?=
 =?us-ascii?Q?9PDTI0+z7ad1WLMaHctq2qtP2VO8o/+RNr+D/s4V3GCUYX4lSCp5tHPhnIRt?=
 =?us-ascii?Q?Uvg4HlKUsc/Nd2ywAUPiLeUAusZCygcQ3TZ5FV4vnCq9o2yp3mq9JS/czv7P?=
 =?us-ascii?Q?UeExS7EPn1SNq/toVVFsrJIUHSGTACMS/cs6nd3sqw9d+ClI4hneCyvgoPmh?=
 =?us-ascii?Q?b9tpH/eWfC9xVWCZsROJcNNdAnXmScNfR2pFeE8BRdyccMIWx4h7j7icAjqG?=
 =?us-ascii?Q?nLHhcdCbPo/q0L5SQvBsmFq/FGMvyKWdSEw/ED/5VXGksXQzzNzTta6rJlT9?=
 =?us-ascii?Q?OkpgW4qJC9dywL5uM4P9VisOMDYOyt8KnRx31pd9/ZwtLa+lh8qDbOc31YqY?=
 =?us-ascii?Q?D+GjF782BlTG92LcBSp7oWfgMsWJYtP+8VOS2AWRCOZa5lytxd04bvtYNs6T?=
 =?us-ascii?Q?UkSNUVhhiRF10G3Rlw/JpO4kyzLgf8Ds6NNlhxqVH3uxbgIrgIpJu0AZiGJP?=
 =?us-ascii?Q?t7wVlvw7mrfPuWXtQ1Zof62goARD19menGb2VBfHI5b6L4shE80B63Q9HftX?=
 =?us-ascii?Q?YvR1UKWxtdVpUJ4mEPASzpGNgopUVUgnpvgD7k2HCKWk7X04uXKKFpmUQS3E?=
 =?us-ascii?Q?WVKPedGQ2DNhrVJa0Ai8mExItSbcOB6/bfC00EY5gd4OTc5qND8cFWAlJ9QJ?=
 =?us-ascii?Q?Yvx8MltJjTvXH9tiE6o=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e04d19-7845-4e12-165e-08d9ba630dce
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:54:44.7180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pmTBmT44qbdWtuOamRiWQCTPBIWAzZjS3q0G0peziap0cWI7ghEGY/geYwduYXx4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5031
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 06, 2021 at 11:39:33PM +0100, Thomas Gleixner wrote:

> @@ -209,10 +209,10 @@ static int setup_msi_msg_address(struct
>  		return -ENODEV;
>  	}
>  
> -	entry = first_pci_msi_entry(dev);
> +	is_64bit = msi_device_has_property(&dev->dev, MSI_PROP_64BIT);

How about  !dev->no_64bit_msi ?

Jason