Date:   Wed, 8 Dec 2021 11:58:16 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Cedric Le Goater <clg@kaod.org>,
        xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Will Deacon <will@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Vinod Koul <vkoul@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
Message-ID: <20211208155816.GZ6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.688216619@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.688216619@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+qJJFjN+ab39S6TkbsBWOnrA2Qhu0Lg7bmLz0bRasCyrNSVAZqUoZLH12o/j?=
 =?us-ascii?Q?mwrtjEJf0Xctb7VWN6RaSJ53vsVyLvz1Fy2dia1dSmWRA7CywsiHRgyhsb4b?=
 =?us-ascii?Q?jbR9ifS79g2y8v124mTT6tk6ms6+cFK+Z9zS2T67m79O9DM2FL6wspNmz0eZ?=
 =?us-ascii?Q?4I2qu91XUZRXe2MfipurcsT84ScnfwbpRaFtKn89PE4VxnGxbc/igLU/ouYQ?=
 =?us-ascii?Q?nmx7DVe73HAfxpZMk21wkfA5ohIwmL3UVudBMSsutoFBrsqTcmh7NeoKcAon?=
 =?us-ascii?Q?mG+d0NFiHSD4oxA8MU65HtSGcrz8hctyn03do7ej4RTNVeiHElhRuWgGU/c4?=
 =?us-ascii?Q?BB+QIJ2X6jdO91L0KjIKom1xvPaM/7vkA2xSAGaEmJvjaCQqvNWx7Fbli6Ih?=
 =?us-ascii?Q?eVaQ9+W7SgOtOQywK7zbMol/wvAeV+HHNKl8XPSfWRbnUBzoTQnwrEMK74pe?=
 =?us-ascii?Q?nrqKcMEMy/bB7ricfLzpgCGamVOMGhWkwwhSZHY7WxicAj2dcoOdMgG9fOkR?=
 =?us-ascii?Q?C76ik4/rd84mTeNGFmjq3k+lxFqyFLN9UpHznhtNZQzOdgnNoCEJM9dnDJne?=
 =?us-ascii?Q?GdND7gpDT0RWpO+QPJjFWecVP0FZuc+C9E8OV7QtA/iQVzDb/WKN4tXCGuuA?=
 =?us-ascii?Q?30FtTnyxhcVdsmLqwVS+p5/LK5KLDon04cdNOUOuMPSYsRy2poGtxjsjNnwG?=
 =?us-ascii?Q?F7/RgSW3Xa6gh2W+xiXNiyP2LCS2yMrFQdcf6RTWHj6s90Uge3pWTeMJtmSJ?=
 =?us-ascii?Q?WJUl3lUv44NmZt6HN4foh5a707vA9SrMfND4fKnI55R3LllCG4fy6UTvdVen?=
 =?us-ascii?Q?b86T1q1yHKg7ygoVMz/hflupeWKPqkdgnssoWdfgPgAx2nco/ltxzp+MqO2B?=
 =?us-ascii?Q?wGyH8hubTFZ87EhalIZZfHOZ0ERUun83C6qsZk+iQpm/26+c6z04q47O0fPI?=
 =?us-ascii?Q?b4yezGpgBsOYTa1S5XS6TxVXXqc2w1f07Q5LIskTLxKXiQWUYA3AhEJFd1Cn?=
 =?us-ascii?Q?5iEppfVFqH+wE289Iymmd91AIntcjlcESu1PORIn/Gg9Q/+3sAfHWK96U+9S?=
 =?us-ascii?Q?KNMTt2tDGMZ2xmGlPkfdqN00D8NqmGg2dyWBblDx3v1y8c07A+QSkKvcU2g0?=
 =?us-ascii?Q?wtXqvAFzMYrhdTSc7xDQU8jeLiZ60rNlSlxilRRirigdqDCnnYZAl5RqW0kJ?=
 =?us-ascii?Q?lGRCTiWGgAAwh4xB9NTn7yj9PZXHS4uFXvLsuJbpRdlfBHgUZCKPCnRDlMuy?=
 =?us-ascii?Q?PyScBDWUAM2c3FozhJFemgpfHij5rJDTwGK0UELT5M2/z5sJM+ijo/RCoi2G?=
 =?us-ascii?Q?ndpn6ak6f5e14Bywc8jzVNa9bH7NMLRRgAuJcuWnX7+1q4aynp/q3BMjWNW/?=
 =?us-ascii?Q?vqfX8yojGFkQnfBcnp6mAWSKQ4TCI6AIWf0uS8XOXoGn5fNGe/EEDjou3HQJ?=
 =?us-ascii?Q?I062LqwAc4+sYXt0xjXfw0Eiq1/In/czgSNH4TPbM2RHURw2irHaCDf4Hq12?=
 =?us-ascii?Q?BCLzW1TE6qevIlh9CiTx7pij3hVcw6/O+IbfcW60nwt1k9pOwKguuLBclDMO?=
 =?us-ascii?Q?e72QxSd7SWVGnrL7Zmg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28a579de-45b7-4536-909e-08d9ba638dd0
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:58:19.4670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bYAPMq42LAnCm/sVgjoOZU1ZAepIR0bIxzYB/ZUFhj2xhN34MlFNK59fq6POtcTv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5351
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
> Store the properties which are interesting for various places so the MSI
> descriptor fiddling can be removed.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V2: Use the setter function
> ---
>  drivers/pci/msi/msi.c |    8 ++++++++
>  1 file changed, 8 insertions(+)

I took more time to look at this, to summarize my remarks on the other
patches

I think we don't need properties. The info in the msi_desc can come
from the pci_dev which we have easy access to. This seems overall
clearer

The notable one is the sysfs, but that is probably better handled by
storing a

  const char *sysfs_label

in the dev->msi and emitting that instead of computing it.

Jason